Chromium Code Reviews Chromium Code Reviews
Issue 120373005:
OnChange event should fire if the multiple selection changes in listbox using mouse (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/events/multiselect-in-listbox-mouse-release-outside.html |
| diff --git a/LayoutTests/fast/events/autoscroll-in-textfield.html b/LayoutTests/fast/events/multiselect-in-listbox-mouse-release-outside.html |
| old mode 100644 |
| new mode 100755 |
| similarity index 60% |
| copy from LayoutTests/fast/events/autoscroll-in-textfield.html |
| copy to LayoutTests/fast/events/multiselect-in-listbox-mouse-release-outside.html |
| index e396e55490b9b8a72b53d0a85e6e927d7d33e5b6..28858ce378fa6312eafc316109d68c24cf38fcd7 |
| --- a/LayoutTests/fast/events/autoscroll-in-textfield.html |
| +++ b/LayoutTests/fast/events/multiselect-in-listbox-mouse-release-outside.html |
| @@ -1,13 +1,21 @@ |
| <html> |
|
tkent
2014/01/06 03:04:58
I prefer putting this file in LayoutTests/fast/for
gnana
2014/01/06 09:15:25
Done.
|
| <head> |
| <script> |
| + |
| function log(msg) |
| { |
| document.getElementById('console').appendChild(document.createTextNode(msg + '\n')); |
| } |
| + |
| + function listBoxSelectChange(s, e) |
| + { |
| + log("PASS"); |
|
tkent
2014/01/06 03:04:58
Please use testPassed() defined in LayoutTests/res
gnana
2014/01/06 09:15:25
Done.
|
| + } |
| function test() |
| { |
| + var lstSelect = document.getElementById('listBoxSelect'); |
| + lstSelect.addEventListener('change', listBoxSelectChange, false); |
| if (window.testRunner) { |
| testRunner.waitUntilDone(); |
|
tkent
2014/01/06 03:04:58
Please import js-test.js and use jsTestIsAsync=tru
gnana
2014/01/06 09:15:25
Done.
|
| testRunner.dumpAsText(); |
|
tkent
2014/01/06 03:04:58
Please import js-test.js and remove this line.
gnana
2014/01/06 09:15:25
Done.
|
| @@ -17,15 +25,15 @@ |
| function autoscrollTestPart1() |
| { |
| - var input = document.getElementById('shortTextField'); |
| + var input = document.getElementById('listBoxSelect'); |
|
tkent
2014/01/06 03:04:58
Using the name |input| for <select> looks unreason
gnana
2014/01/06 09:15:25
Done.
|
| if (window.eventSender) { |
| var x = input.offsetLeft + 7; |
| var y = input.offsetTop + 7; |
| eventSender.dragMode = false; |
| eventSender.mouseMoveTo(x, y); |
| eventSender.mouseDown(); |
| - eventSender.mouseMoveTo(x + 20, y); |
| - eventSender.mouseMoveTo(x + 600, y); |
| + eventSender.mouseMoveTo(x, y + 20); |
|
tkent
2014/01/06 03:04:58
Does this work if we move the mouse pointer horizo
gnana
2014/01/06 09:15:25
yes, it works
|
| + eventSender.mouseMoveTo(x, y + 600); |
| } |
| setTimeout(autoscrollTestPart2, 100); |
| } |
| @@ -36,23 +44,22 @@ |
| eventSender.mouseUp(); |
| var input = document.getElementById('shortTextField'); |
|
tkent
2014/01/06 03:04:58
This variable is not used.
gnana
2014/01/06 09:15:25
Done.
|
| - if (input.scrollLeft == 0) |
| - log("FAILED the textfield should have been scrolled"); |
| - else |
| - log("PASSED"); |
| - |
| + |
| if (window.testRunner) |
| testRunner.notifyDone(); |
|
tkent
2014/01/06 03:04:58
Please import js-test.js and use finishJSTest().
gnana
2014/01/06 09:15:25
Done.
|
| - } |
| + } |
| </script> |
| </head> |
| <body onload="test()"> |
| <div id="console"> |
| - <input id="shortTextField" value="This text should be autoscrollable and if it doesn't then the test failed" size="25"> |
| - https://bugs.webkit.org/show_bug.cgi?id=20201 <br> |
| - To do the test manually you have to try triggering the autoscroll by starting the dragging from within the text field and moving to the right. If the autoscroll occurs the test has PASSED.<br> |
| + <select id="listBoxSelect" size="5" multiple="multiple"> |
| + <option value="option 1">Option 1</option> |
| + <option value="option 2">Option 2</option> |
| + <option value="option 3">Option 3</option> |
| + <option value="option 4">Option 4</option> |
| + <option value="option 5">Option 5</option> |
| + </select> |
| </div> |
| - |
| </body> |
| </html> |
