Source/core/rendering/RenderListBox.cpp - Issue 120373005: OnChange event should fire if the multiple selection changes in listbox using mouse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderListBox.cpp

Issue 120373005: OnChange event should fire if the multiple selection changes in listbox using mouse (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: removed unnecessary blank lines in layout test Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderListBox.cpp

diff --git a/Source/core/rendering/RenderListBox.cpp b/Source/core/rendering/RenderListBox.cpp

old mode 100644

new mode 100755

index 602b716ea95665724b86224f52d8f6c4d22d95e8..996c3c24c6254dcfa4ba5a039c22dbc9a84f59f7

--- a/Source/core/rendering/RenderListBox.cpp

+++ b/Source/core/rendering/RenderListBox.cpp

@@ -591,7 +591,10 @@ void RenderListBox::stopAutoscroll()

if (selectElement()->isDisabledFormControl())

return;

- selectElement()->listBoxOnChange();

+ if (!selectElement()->isOnChangeFired() && !selectElement()->isLastOnChangeSelectionEmpty()) {

+ selectElement()->listBoxOnChange();

+ selectElement()->setOnChangeFired(true);

+ }

}

bool RenderListBox::scrollToRevealElementAtListIndex(int index)

« Source/core/html/HTMLSelectElement.cpp ('K') | « Source/core/page/AutoscrollController.cpp ('k') | no next file » | no next file with comments »