Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 120373003: Revert of Make arguments to Element methods non-optional (Closed)

Created:
7 years ago by eseidel
Modified:
7 years ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/105883012/ Reason for revert: Broken twitter. Reverting is easy, so doing that first, can land a more surgical fix. TBR=jochen@chromium.org,philipj@opera.com BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164266

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
eseidel
Created Revert of Make arguments to Element methods non-optional
7 years ago (2013-12-21 02:13:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/120373003/1
7 years ago (2013-12-21 02:14:03 UTC) #2
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years ago (2013-12-21 02:14:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/120373003/1
7 years ago (2013-12-21 02:15:05 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-21 04:12:27 UTC) #5
Message was sent while issue was closed.
Change committed as 164266

Powered by Google App Engine
This is Rietveld 408576698