components/bookmarks/browser/bookmark_utils.h - Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_utils.h

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/bookmarks/browser/bookmark_model.h ('K') | « components/bookmarks/browser/bookmark_model.cc ('k') | components/bookmarks/browser/bookmark_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_utils.h

diff --git a/components/bookmarks/browser/bookmark_utils.h b/components/bookmarks/browser/bookmark_utils.h

index 57bd4bb8291bbd78d87a07dcd3fd35bd5715649f..debaba85e751d1b5396fa109c3f9d3d8554062a8 100644

--- a/components/bookmarks/browser/bookmark_utils.h

+++ b/components/bookmarks/browser/bookmark_utils.h

@@ -23,7 +23,6 @@ class PrefRegistrySyncable;

// systems that involve indexing and searching bookmarks.

namespace bookmarks {

-class BookmarkClient;

class BookmarkModel;

class BookmarkNode;

@@ -139,8 +138,8 @@ base::string16 CleanUpUrlForMatching(

base::string16 CleanUpTitleForMatching(const base::string16& title);

// Returns true if all the |nodes| can be edited by the user,

-// as determined by BookmarkClient::CanBeEditedByUser().

-bool CanAllBeEditedByUser(BookmarkClient* client,

+// as determined by BookmarkModel::CanBeEditedByUser().

+bool CanAllBeEditedByUser(BookmarkModel* model,

const std::vector<const BookmarkNode*>& nodes);

// Returns true if |url| has a bookmark in the |model| that can be edited