components/bookmarks/browser/bookmark_client.cc - Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_client.cc

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/bookmarks/browser/bookmark_client.h ('K') | « components/bookmarks/browser/bookmark_client.h ('k') | components/bookmarks/browser/bookmark_model.h » ('j') | components/bookmarks/browser/bookmark_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_client.cc

diff --git a/components/bookmarks/browser/bookmark_client.cc b/components/bookmarks/browser/bookmark_client.cc

index fc22f3ac51a536942c3bc39bceda885d77683e74..8d505764e76eeb54b43b0316f0a00fe3020530eb 100644

--- a/components/bookmarks/browser/bookmark_client.cc

+++ b/components/bookmarks/browser/bookmark_client.cc

@@ -8,10 +8,6 @@

namespace bookmarks {

-bool BookmarkClient::PreferTouchIcon() {

- return false;

base::CancelableTaskTracker::TaskId BookmarkClient::GetFaviconImageForPageURL(

const GURL& page_url,

favicon_base::IconType type,