chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.h » ('j') | components/bookmarks/browser/bookmark_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index 8d5ebeef243ac54815380264a7ab56f14d06240a..660244912ef859ee7365f39db9075b2acd2f628f 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -17,8 +17,6 @@

#include "chrome/app/chrome_command_ids.h" // IDC_*

#import "chrome/browser/app_controller_mac.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

-#include "chrome/browser/bookmarks/chrome_bookmark_client.h"

-#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/devtools/devtools_window.h"

#include "chrome/browser/extensions/extension_commands_global_registry.h"

@@ -1773,12 +1771,9 @@ using content::WebContents;

if (!bookmarkBubbleController_) {

BookmarkModel* model =

BookmarkModelFactory::GetForProfile(browser_->profile());

- ChromeBookmarkClient* client =

- ChromeBookmarkClientFactory::GetForProfile(browser_->profile());

const BookmarkNode* node = model->GetMostRecentlyAddedUserNodeForURL(url);

bookmarkBubbleController_ =

[[BookmarkBubbleController alloc] initWithParentWindow:[self window]

- client:client

model:model

node:node

alreadyBookmarked:alreadyMarked];