Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5584)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm
index d979bbe2972e2eec18402a2986d1a45e7ea04edd..812e5b547e0a3383744fa856c0cc91a18d0ab913 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm
@@ -9,8 +9,6 @@
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
-#include "chrome/browser/bookmarks/chrome_bookmark_client.h"
-#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"
#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
@@ -93,11 +91,8 @@ class BookmarkBubbleControllerTest : public CocoaProfileTest {
controller_ = nil;
}
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
- ChromeBookmarkClient* client =
- ChromeBookmarkClientFactory::GetForProfile(profile());
controller_ = [[BookmarkBubbleController alloc]
initWithParentWindow:browser()->window()->GetNativeWindow()
- client:client
model:model
node:node
alreadyBookmarked:YES];
@@ -396,12 +391,9 @@ TEST_F(BookmarkBubbleControllerTest, PopUpSelectionChanged) {
// them pressing escape. The bookmark should not be there.
TEST_F(BookmarkBubbleControllerTest, EscapeRemovesNewBookmark) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
- ChromeBookmarkClient* client =
- ChromeBookmarkClientFactory::GetForProfile(profile());
const BookmarkNode* node = CreateTestBookmark();
BookmarkBubbleController* controller = [[BookmarkBubbleController alloc]
initWithParentWindow:browser()->window()->GetNativeWindow()
- client:client
model:model
node:node
alreadyBookmarked:NO]; // The last param is the key difference.

Powered by Google App Engine
This is Rietveld 408576698