chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h - Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm » ('j') | components/bookmarks/browser/bookmark_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

index 708ae7181668ae5ce0ae590317ecac757e8bb6c5..3eaf012c07bb5d2c6809ea396651e06416a2d5bf 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

@@ -9,7 +9,6 @@

#import "chrome/browser/ui/cocoa/base_bubble_controller.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h"

-class ChromeBookmarkClient;

@class BookmarkBubbleController;

@class BookmarkSyncPromoController;

@@ -26,7 +25,6 @@ class BookmarkNode;

@private

// |client_|, |model_| and |node_| are weak and owned by the current browser's

// profile.

- ChromeBookmarkClient* client_; // weak

bookmarks::BookmarkModel* model_; // weak

const bookmarks::BookmarkNode* node_; // weak

@@ -56,7 +54,6 @@ class BookmarkNode;

// it desires it to be visible on the screen. It is not shown by the

// init routine. Closing of the window happens implicitly on dealloc.

- (id)initWithParentWindow:(NSWindow*)parentWindow

- client:(ChromeBookmarkClient*)client

model:(bookmarks::BookmarkModel*)model

node:(const bookmarks::BookmarkNode*)node

alreadyBookmarked:(BOOL)alreadyBookmarked;