Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
index 92ab0faed3654b5112ac632782f6e10250a2c579..1df45560bdb03bb4b66ab157bdfbb37951071016 100644
--- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
@@ -9,8 +9,6 @@
#include "base/prefs/pref_service.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
-#include "chrome/browser/bookmarks/chrome_bookmark_client.h"
-#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/bookmarks/bookmark_editor.h"
@@ -320,10 +318,8 @@ base::string16 BookmarkContextMenuController::GetLabelForCommandId(
undo_manager()->GetRedoLabel();
}
if (command_id == IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS) {
- ChromeBookmarkClient* client =
- ChromeBookmarkClientFactory::GetForProfile(profile_);
return l10n_util::GetStringFUTF16(IDS_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS,
- client->managed_node()->GetTitle());
+ model_->managed_node()->GetTitle());
}
NOTREACHED();
@@ -348,7 +344,7 @@ bool BookmarkContextMenuController::IsCommandIdEnabled(int command_id) const {
bool is_root_node = selection_.size() == 1 &&
selection_[0]->parent() == model_->root_node();
bool can_edit = prefs->GetBoolean(bookmarks::prefs::kEditBookmarksEnabled) &&
- bookmarks::CanAllBeEditedByUser(model_->client(), selection_);
+ bookmarks::CanAllBeEditedByUser(model_, selection_);
IncognitoModePrefs::Availability incognito_avail =
IncognitoModePrefs::GetAvailability(prefs);
@@ -388,7 +384,7 @@ bool BookmarkContextMenuController::IsCommandIdEnabled(int command_id) const {
case IDC_BOOKMARK_BAR_NEW_FOLDER:
case IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK:
- return can_edit && model_->client()->CanBeEditedByUser(parent_) &&
+ return can_edit && model_->CanBeEditedByUser(parent_) &&
bookmarks::GetParentForNewNodes(parent_, selection_, NULL) != NULL;
case IDC_BOOKMARK_BAR_ALWAYS_SHOW:
@@ -417,9 +413,7 @@ bool BookmarkContextMenuController::IsCommandIdVisible(int command_id) const {
if (command_id == IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS) {
// The option to hide the Managed Bookmarks folder is only available if
// there are any managed bookmarks configured at all.
- ChromeBookmarkClient* client =
- ChromeBookmarkClientFactory::GetForProfile(profile_);
- return !client->managed_node()->empty();
+ return !model_->managed_node()->empty();
}
return true;

Powered by Google App Engine
This is Rietveld 408576698