Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc b/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
index 7adc3d9e0912689759dd37e9962114d6f768e686..caaaea91a24cb5aa9ebea10051a8206009a79363 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
@@ -5,8 +5,6 @@
#include "base/prefs/pref_service.h"
#include "base/values.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
-#include "chrome/browser/bookmarks/chrome_bookmark_client.h"
-#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
@@ -28,8 +26,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Bookmarks) {
// can read them and can't modify them.
Profile* profile = browser()->profile();
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile);
- ChromeBookmarkClient* client =
- ChromeBookmarkClientFactory::GetForProfile(profile);
bookmarks::test::WaitForBookmarkModelToLoad(model);
{
@@ -43,7 +39,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Bookmarks) {
node->Set("children", new base::ListValue());
list.Append(node);
profile->GetPrefs()->Set(bookmarks::prefs::kManagedBookmarks, list);
- ASSERT_EQ(2, client->managed_node()->child_count());
+ ASSERT_EQ(2, model->managed_node()->child_count());
}
{
@@ -57,7 +53,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Bookmarks) {
node->Set("children", new base::ListValue());
list.Append(node);
profile->GetPrefs()->Set(bookmarks::prefs::kSupervisedBookmarks, list);
- ASSERT_EQ(2, client->supervised_node()->child_count());
+ ASSERT_EQ(2, model->supervised_node()->child_count());
}
ASSERT_TRUE(RunExtensionTest("bookmarks")) << message_;

Powered by Google App Engine
This is Rietveld 408576698