chrome/browser/android/bookmarks/bookmarks_bridge.h - Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.h

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/bookmarks/bookmarks_bridge.h

diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.h b/chrome/browser/android/bookmarks/bookmarks_bridge.h

index cb4925ef0795aa912efee5480e370365482362be..feb10e2249e16c2bb3e41622bf3a68efce48e677 100644

--- a/chrome/browser/android/bookmarks/bookmarks_bridge.h

+++ b/chrome/browser/android/bookmarks/bookmarks_bridge.h

@@ -12,7 +12,6 @@

#include "base/basictypes.h"

#include "base/compiler_specific.h"

#include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"

-#include "chrome/browser/bookmarks/chrome_bookmark_client.h"

#include "components/bookmarks/browser/base_bookmark_model_observer.h"

#include "components/bookmarks/common/android/bookmark_id.h"

@@ -214,7 +213,6 @@ class BookmarksBridge : public bookmarks::BaseBookmarkModelObserver,

Profile* profile_;

JavaObjectWeakGlobalRef weak_java_ref_;

bookmarks::BookmarkModel* bookmark_model_; // weak

- ChromeBookmarkClient* client_; // weak

scoped_ptr<bookmarks::ScopedGroupBookmarkActions> grouped_bookmark_actions_;

// Information about the Partner bookmarks (must check for IsLoaded()).

« no previous file with comments | « no previous file | chrome/browser/android/bookmarks/bookmarks_bridge.cc » ('j') | components/bookmarks/browser/bookmark_client.h » ('J')