Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/bookmarks/chrome_bookmark_client.h

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_ 5 #ifndef CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_
6 #define CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_ 6 #define CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/deferred_sequenced_task_runner.h" 11 #include "base/deferred_sequenced_task_runner.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "components/bookmarks/browser/base_bookmark_model_observer.h"
14 #include "components/bookmarks/browser/bookmark_client.h" 13 #include "components/bookmarks/browser/bookmark_client.h"
15 14
16 class GURL; 15 class GURL;
17 class Profile; 16 class Profile;
18 17
19 namespace base { 18 namespace base {
20 class ListValue; 19 class ListValue;
21 } 20 }
22 21
23 namespace bookmarks { 22 namespace bookmarks {
24 class BookmarkModel; 23 class BookmarkModel;
25 class BookmarkNode; 24 class BookmarkNode;
26 class BookmarkPermanentNode; 25 class BookmarkPermanentNode;
27 class ManagedBookmarksTracker; 26 class ManagedBookmarksTracker;
28 } 27 }
29 28
30 class ChromeBookmarkClient : public bookmarks::BookmarkClient, 29 class ChromeBookmarkClient : public bookmarks::BookmarkClient {
31 public bookmarks::BaseBookmarkModelObserver {
32 public: 30 public:
33 explicit ChromeBookmarkClient(Profile* profile); 31 explicit ChromeBookmarkClient(Profile* profile);
34 ~ChromeBookmarkClient() override; 32 ~ChromeBookmarkClient() override;
35 33
36 void Init(bookmarks::BookmarkModel* model); 34 void Init(bookmarks::BookmarkModel* model);
37 35
38 // KeyedService:
39 void Shutdown() override;
40
41 // The top-level managed bookmarks folder, defined by an enterprise policy.
42 const bookmarks::BookmarkNode* managed_node() { return managed_node_; }
43 // The top-level supervised bookmarks folder, defined by the custodian of a
44 // supervised user.
45 const bookmarks::BookmarkNode* supervised_node() { return supervised_node_; }
46
47 // bookmarks::BookmarkClient: 36 // bookmarks::BookmarkClient:
48 bool PreferTouchIcon() override;
49 base::CancelableTaskTracker::TaskId GetFaviconImageForPageURL( 37 base::CancelableTaskTracker::TaskId GetFaviconImageForPageURL(
50 const GURL& page_url, 38 const GURL& page_url,
51 favicon_base::IconType type, 39 favicon_base::IconType type,
52 const favicon_base::FaviconImageCallback& callback, 40 const favicon_base::FaviconImageCallback& callback,
53 base::CancelableTaskTracker* tracker) override; 41 base::CancelableTaskTracker* tracker) override;
54 bool SupportsTypedCountForNodes() override; 42 bool SupportsTypedCountForNodes() override;
55 void GetTypedCountForNodes( 43 void GetTypedCountForNodes(
56 const NodeSet& nodes, 44 const NodeSet& nodes,
57 NodeTypedCountPairs* node_typed_count_pairs) override; 45 NodeTypedCountPairs* node_typed_count_pairs) override;
58 bool IsPermanentNodeVisible(
59 const bookmarks::BookmarkPermanentNode* node) override;
60 void RecordAction(const base::UserMetricsAction& action) override; 46 void RecordAction(const base::UserMetricsAction& action) override;
61 bookmarks::LoadExtraCallback GetLoadExtraNodesCallback() override; 47 bookmarks::LoadExtraCallback GetLoadExtraNodesCallback(
62 bool CanSetPermanentNodeTitle( 48 scoped_ptr<bookmarks::BookmarkPermanentNode> managed_node,
63 const bookmarks::BookmarkNode* permanent_node) override; 49 scoped_ptr<bookmarks::BookmarkPermanentNode> supervised_node,
64 bool CanSyncNode(const bookmarks::BookmarkNode* node) override; 50 const ExtraNodeLoadedCallback& callback) override;
65 bool CanBeEditedByUser(const bookmarks::BookmarkNode* node) override; 51 void DoneLoading(bookmarks::BookmarkPermanentNode* managed_node,
52 bookmarks::BookmarkPermanentNode* supervised_node) override;
66 53
67 private: 54 private:
68 // bookmarks::BaseBookmarkModelObserver:
69 void BookmarkModelChanged() override;
70
71 // bookmarks::BookmarkModelObserver:
72 void BookmarkModelLoaded(bookmarks::BookmarkModel* model,
73 bool ids_reassigned) override;
74
75 // Helper for GetLoadExtraNodesCallback(). 55 // Helper for GetLoadExtraNodesCallback().
76 static bookmarks::BookmarkPermanentNodeList LoadExtraNodes( 56 static bookmarks::BookmarkPermanentNodeList LoadExtraNodes(
77 scoped_ptr<bookmarks::BookmarkPermanentNode> managed_node, 57 scoped_ptr<bookmarks::BookmarkPermanentNode> managed_node,
78 scoped_ptr<base::ListValue> initial_managed_bookmarks, 58 scoped_ptr<base::ListValue> initial_managed_bookmarks,
79 scoped_ptr<bookmarks::BookmarkPermanentNode> supervised_node, 59 scoped_ptr<bookmarks::BookmarkPermanentNode> supervised_node,
80 scoped_ptr<base::ListValue> initial_supervised_bookmarks, 60 scoped_ptr<base::ListValue> initial_supervised_bookmarks,
61 const ExtraNodeLoadedCallback& callback,
81 int64* next_node_id); 62 int64* next_node_id);
82 63
83 // Returns the management domain that configured the managed bookmarks, 64 // Returns the management domain that configured the managed bookmarks,
84 // or an empty string. 65 // or an empty string.
85 std::string GetManagedBookmarksDomain(); 66 std::string GetManagedBookmarksDomain();
86 67
87 Profile* profile_; 68 Profile* profile_;
88 69
89 // Pointer to the BookmarkModel. Will be non-NULL from the call to Init to
90 // the call to Shutdown. Must be valid for the whole interval.
91 bookmarks::BookmarkModel* model_;
92
93 // Managed bookmarks are defined by an enterprise policy. 70 // Managed bookmarks are defined by an enterprise policy.
94 scoped_ptr<bookmarks::ManagedBookmarksTracker> managed_bookmarks_tracker_; 71 scoped_ptr<bookmarks::ManagedBookmarksTracker> managed_bookmarks_tracker_;
95 // The top-level managed bookmarks folder.
96 bookmarks::BookmarkPermanentNode* managed_node_;
97 72
98 // Supervised bookmarks are defined by the custodian of a supervised user. 73 // Supervised bookmarks are defined by the custodian of a supervised user.
99 scoped_ptr<bookmarks::ManagedBookmarksTracker> supervised_bookmarks_tracker_; 74 scoped_ptr<bookmarks::ManagedBookmarksTracker> supervised_bookmarks_tracker_;
100 // The top-level supervised bookmarks folder.
101 bookmarks::BookmarkPermanentNode* supervised_node_;
102 75
103 DISALLOW_COPY_AND_ASSIGN(ChromeBookmarkClient); 76 DISALLOW_COPY_AND_ASSIGN(ChromeBookmarkClient);
104 }; 77 };
105 78
106 #endif // CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_ 79 #endif // CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698