DevTools: nuke LocalStorage settings once again when upgrading from settings v12 to v13

Source/devtools/front_end/common/Settings.js

Index: Source/devtools/front_end/common/Settings.js
diff --git a/Source/devtools/front_end/common/Settings.js b/Source/devtools/front_end/common/Settings.js
index fb7c3756ae82906495e39e4a39e54d4b32e8d74a..c0acc88a9a3dd4ec6fe51a7e105d18fcf65382bf 100644
--- a/Source/devtools/front_end/common/Settings.js
+++ b/Source/devtools/front_end/common/Settings.js
@@ -565,6 +565,17 @@ WebInspector.VersionController.prototype = {
 
     _updateVersionFrom11To12: function()
     {
+        this._migrateSettingsFromLocalStorage();

[pfeldman, 2015/06/23 13:58:02]

We can't modify things in the past, assume users are already on v12.

[alph, 2015/06/23 14:11:36]

you probably took it offline, but could you please excuse my curiosity, what's
the point of doing it twice for users migrating from 11 to 13?

+    },
+
+    _updateVersionFrom12To13: function()
+    {
+        this._migrateSettingsFromLocalStorage();

[pfeldman, 2015/06/23 13:58:03]

You should not migrate more than once. Should we just nuke the version off
localStorage?

+        WebInspector.settings.createSetting("timelineOverviewMode", "").remove();
+    },
+
+    _migrateSettingsFromLocalStorage: function()
+    {
         // This step migrates all the settings except for the ones below into the browser profile.
         var localSettings = [ "advancedSearchConfig", "breakpoints", "consoleHistory", "domBreakpoints", "eventListenerBreakpoints",
                               "fileSystemMapping", "lastSelectedSourcesSidebarPaneTab", "previouslyViewedFiles",
@@ -581,11 +592,6 @@ WebInspector.VersionController.prototype = {
         }
     },
 
-    _updateVersionFrom12To13: function()
-    {
-        WebInspector.settings.createSetting("timelineOverviewMode", "").remove();
-    },
-
     /**
      * @param {!WebInspector.Setting} breakpointsSetting
      * @param {number} maxBreakpointsCount