DevTools: nuke LocalStorage settings once again when upgrading from settings v12 to v13

DevTools: nuke LocalStorage settings once again when upgrading from settings v12 to v13

This was supposed to happen when upgrading from v11 to v12, but somehow
didn't, so we kept getting v12 from LocalStorage and re-run upgrading
to v13 all the time. Now explicitly migrate LocalStorage stuff for v13
as well.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197656

[caseq, 2015-06-23 13:55:19]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[pfeldman, 2015-06-23 13:58:03]

https://codereview.chromium.org/1203703002/diff/1/Source/devtools/front_end/c...
File Source/devtools/front_end/common/Settings.js (right):

https://codereview.chromium.org/1203703002/diff/1/Source/devtools/front_end/c...
Source/devtools/front_end/common/Settings.js:568:
this._migrateSettingsFromLocalStorage();
We can't modify things in the past, assume users are already on v12.

https://codereview.chromium.org/1203703002/diff/1/Source/devtools/front_end/c...
Source/devtools/front_end/common/Settings.js:573:
this._migrateSettingsFromLocalStorage();
You should not migrate more than once. Should we just nuke the version off
localStorage?

[pfeldman, 2015-06-23 14:01:47]

lgtm

[caseq, 2015-06-23 14:06:46]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2015-06-23 14:07:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1203703002/1

[alph, 2015-06-23 14:11:35]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2015-06-23 14:11:36]

https://codereview.chromium.org/1203703002/diff/1/Source/devtools/front_end/c...
File Source/devtools/front_end/common/Settings.js (right):

https://codereview.chromium.org/1203703002/diff/1/Source/devtools/front_end/c...
Source/devtools/front_end/common/Settings.js:568:
this._migrateSettingsFromLocalStorage();
you probably took it offline, but could you please excuse my curiosity, what's
the point of doing it twice for users migrating from 11 to 13?

[pfeldman, 2015-06-23 14:14:17]

On 2015/06/23 14:11:36, alph wrote:
>
https://codereview.chromium.org/1203703002/diff/1/Source/devtools/front_end/c...
> File Source/devtools/front_end/common/Settings.js (right):
> 
>
https://codereview.chromium.org/1203703002/diff/1/Source/devtools/front_end/c...
> Source/devtools/front_end/common/Settings.js:568:
> this._migrateSettingsFromLocalStorage();
> you probably took it offline, but could you please excuse my curiosity, what's
> the point of doing it twice for users migrating from 11 to 13?

We agreed to do it twice for the sake of the users missing the upgrade for
unknown reason.
We agreed to do it twice for the sake of the users missing the upgrade for
unknown reason.

[alph, 2015-06-23 14:24:09]

On 2015/06/23 14:14:17, pfeldman wrote:
> On 2015/06/23 14:11:36, alph wrote:
> >
>
https://codereview.chromium.org/1203703002/diff/1/Source/devtools/front_end/c...
> > File Source/devtools/front_end/common/Settings.js (right):
> > 
> >
>
https://codereview.chromium.org/1203703002/diff/1/Source/devtools/front_end/c...
> > Source/devtools/front_end/common/Settings.js:568:
> > this._migrateSettingsFromLocalStorage();
> > you probably took it offline, but could you please excuse my curiosity,
what's
> > the point of doing it twice for users migrating from 11 to 13?
> 
> We agreed to do it twice for the sake of the users missing the upgrade for
> unknown reason.
> We agreed to do it twice for the sake of the users missing the upgrade for
> unknown reason.

Thanks, that explains!
I'd suggest doing it trice for more confidence.

[caseq, 2015-06-23 14:29:19]

> 
> Thanks, that explains!
> I'd suggest doing it trice for more confidence.

This is going to be even easier now that we have factored the upgrade logic out
into a reusable method!

Apparently, the upgrade from v11 to v12 is not not what it used to be originally
and we may have bumped the version without actually removing the LocalSettings
key. This is certainly a field where daring code archeologists may contribute by
shedding more light of the original v11 to v12 upgrade logic.

[commit-bot: I haz the power, 2015-06-23 15:25:39]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197656