Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1203693002: Unhide 'window.console' by renaming console variable in layout tests (Closed)

Created:
5 years, 6 months ago by Srirama
Modified:
5 years, 5 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Unhide 'window.console' by renaming console variable in layout tests There is a 'console' variable in layout tests which is hiding 'window.console', so 'window.console' is not working in layout tests. Renamed it from 'console' to 'consoleDiv' so that 'window.console' can be used for debugging purpose. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198132

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M LayoutTests/media/encrypted-media/encrypted-media-utils.js View 1 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/media/video-test.js View 1 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/media/w3c-media-utils.js View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Srirama
Came across this while working on some of the failed layout test cases. Though it ...
5 years, 6 months ago (2015-06-23 14:01:12 UTC) #2
philipj_slow
LGTM with nit. Also remove BUG=none from description, I've been told. https://codereview.chromium.org/1203693002/diff/1/LayoutTests/media/video-test.js File LayoutTests/media/video-test.js (right): ...
5 years, 5 months ago (2015-07-01 08:32:25 UTC) #3
Srirama
Thanks for the review https://codereview.chromium.org/1203693002/diff/1/LayoutTests/media/video-test.js File LayoutTests/media/video-test.js (right): https://codereview.chromium.org/1203693002/diff/1/LayoutTests/media/video-test.js#newcode4 LayoutTests/media/video-test.js:4: var consoleLog = null; On ...
5 years, 5 months ago (2015-07-01 09:48:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203693002/20001
5 years, 5 months ago (2015-07-01 09:49:04 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 10:52:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198132

Powered by Google App Engine
This is Rietveld 408576698