Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1203653003: Don't insert elements transitions into normalized maps (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't insert elements transitions into normalized maps BUG=chromium:499790 LOG=n Committed: https://crrev.com/c49659b00823aeffb223765a97fae9c422559c40 Cr-Commit-Position: refs/heads/master@{#29233}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -40 lines) Patch
M src/objects.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 3 5 chunks +7 lines, -31 lines 0 comments Download
M src/transitions.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-499790.js View 1 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-23 13:07:58 UTC) #2
Igor Sheludko
lgtm
5 years, 6 months ago (2015-06-23 13:34:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203653003/50001
5 years, 6 months ago (2015-06-23 13:45:16 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 6 months ago (2015-06-23 14:33:11 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 14:33:25 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c49659b00823aeffb223765a97fae9c422559c40
Cr-Commit-Position: refs/heads/master@{#29233}

Powered by Google App Engine
This is Rietveld 408576698