Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1203653002: [android] Completly move path logic to gyp config. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[android] Completly move path logic to gyp config. BUG=chromium:502176 LOG=n Committed: https://crrev.com/d70419e47403cf74cf88c2c08e253a0ef14eb9fc Cr-Commit-Position: refs/heads/master@{#29245}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -66 lines) Patch
M Makefile View 4 chunks +1 line, -12 lines 0 comments Download
M Makefile.android View 1 2 chunks +8 lines, -47 lines 0 comments Download
M build/standalone.gypi View 8 chunks +30 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203653002/20001
5 years, 6 months ago (2015-06-23 11:52:58 UTC) #2
Michael Achenbach
PTAL
5 years, 6 months ago (2015-06-23 11:53:21 UTC) #4
Michael Achenbach
PTAL at patch 3
5 years, 6 months ago (2015-06-23 11:54:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203653002/40001
5 years, 6 months ago (2015-06-23 12:25:26 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-23 12:49:33 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-23 15:00:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203653002/40001
5 years, 6 months ago (2015-06-24 05:34:01 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-24 05:35:12 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 05:35:23 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d70419e47403cf74cf88c2c08e253a0ef14eb9fc
Cr-Commit-Position: refs/heads/master@{#29245}

Powered by Google App Engine
This is Rietveld 408576698