gm/offsetimagefilter.cpp - Issue 1203613004: Fix memory leak in simple-offsetimagefilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/offsetimagefilter.cpp

Issue 1203613004: Fix memory leak in simple-offsetimagefilter (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/offsetimagefilter.cpp

diff --git a/gm/offsetimagefilter.cpp b/gm/offsetimagefilter.cpp

index 6645a98b611fd0d6db48bc2397cfc5b8c30065a0..4c8242a4b22741cdd09fa64e46f2cd1292e1f20f 100644

--- a/gm/offsetimagefilter.cpp

+++ b/gm/offsetimagefilter.cpp

@@ -143,7 +143,9 @@ protected:

canvas->save();

canvas->clipRect(*clipR);

}

- p.setImageFilter(imgf);

+ if (imgf) {

+ p.setImageFilter(imgf)->unref();

+ }

p.setColor(0x66FF0000);

canvas->drawRect(r, p);

« no previous file with comments | « no previous file | no next file » | no next file with comments »