Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 1203613003: Make inSameLine() in VisibleUnits.cpp to work with positions in composed tree (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make inSameLine() in VisibleUnits.cpp to work with positions in composed tree This patch makes |inSameLine()|, which is used in |VisiblePosition| constructor, along with introducing composed tree versions of called functions, to work with positions in composed tree for preparaing |VisiblePostion| constructor to canonicalize a position in composed tree instead of DOM tree. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197726

Patch Set 1 : all in one #

Patch Set 2 : 2015-06-24T12:35:06 Import EditingTestBase #

Patch Set 3 : 2015-06-24T16:52:19 Rebase #

Patch Set 4 : 2015-06-24T16:57:02 Add EditingTestBase::updateLayoutAndStyleForPainting() #

Total comments: 2

Patch Set 5 : 2015-06-24T17:52:54 Get rid of redundant explict in RenderedPosition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -4 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/EditingTestBase.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/EditingTestBase.cpp View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/editing/PositionWithAffinity.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/PositionWithAffinity.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/RenderedPosition.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 3 chunks +12 lines, -2 lines 0 comments Download
A Source/core/editing/VisibleUnitsTest.cpp View 1 1 chunk +55 lines, -0 lines 0 comments Download
M Source/core/editing/htmlediting.h View 1 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 4 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-24 07:56:00 UTC) #2
tkent
lgtm https://codereview.chromium.org/1203613003/diff/60001/Source/core/editing/RenderedPosition.h File Source/core/editing/RenderedPosition.h (right): https://codereview.chromium.org/1203613003/diff/60001/Source/core/editing/RenderedPosition.h#newcode51 Source/core/editing/RenderedPosition.h:51: explicit RenderedPosition(const PositionInComposedTree&, EAffinity); remove |explicit|
4 years, 10 months ago (2015-06-24 08:03:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203613003/80001
4 years, 10 months ago (2015-06-24 08:54:41 UTC) #6
yosin_UTC9
Thanks! https://codereview.chromium.org/1203613003/diff/60001/Source/core/editing/RenderedPosition.h File Source/core/editing/RenderedPosition.h (right): https://codereview.chromium.org/1203613003/diff/60001/Source/core/editing/RenderedPosition.h#newcode51 Source/core/editing/RenderedPosition.h:51: explicit RenderedPosition(const PositionInComposedTree&, EAffinity); On 2015/06/24 08:03:14, tkent ...
4 years, 10 months ago (2015-06-24 09:09:04 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 09:58:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197726

Powered by Google App Engine
This is Rietveld 408576698