Enables win64 build of yuv_convert_simd_x86 without rolling x86inc.asm forward.

Enables win64 build of yuv_convert_simd_x86 without rolling x86inc.asm forward.

BUG=172129, 166496
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179379

[wolenetz, 2013-01-25 23:54:38]

It turns out only minimal changes are required to the existing x86inc.asm to get
win64 compilation enabled for yuv_convert_simd_x86 target.  No roll to current
x86inc.asm from x264 appears to be required.  A couple gyp/gypi files also
updated to enable this piece.

hbono@: please review x86inc.asm
dalecurtis@: please review media.gyp
fgalligan@: please review yasm_compile.gypi (ffmpeg still compiles on win64,
libvpx could be impacted but it isn't working yet regardless)

[fgalligan1, 2013-01-26 01:39:12]

On 2013/01/25 23:54:38, wolenetz wrote:
> It turns out only minimal changes are required to the existing x86inc.asm to
get
> win64 compilation enabled for yuv_convert_simd_x86 target.  No roll to current
> x86inc.asm from x264 appears to be required.  A couple gyp/gypi files also
> updated to enable this piece.
> 
> hbono@: please review x86inc.asm
> dalecurtis@: please review media.gyp
> fgalligan@: please review yasm_compile.gypi (ffmpeg still compiles on win64,
> libvpx could be impacted but it isn't working yet regardless)

64bit libvpx on windows builds with the change to yasm_compile.gypi.

[fgalligan1, 2013-01-26 01:40:42]

On 2013/01/26 01:39:12, fgalligan1 wrote:
> On 2013/01/25 23:54:38, wolenetz wrote:
> > It turns out only minimal changes are required to the existing x86inc.asm to
> get
> > win64 compilation enabled for yuv_convert_simd_x86 target.  No roll to
current
> > x86inc.asm from x264 appears to be required.  A couple gyp/gypi files also
> > updated to enable this piece.
> > 
> > hbono@: please review x86inc.asm
> > dalecurtis@: please review media.gyp
> > fgalligan@: please review yasm_compile.gypi (ffmpeg still compiles on win64,
> > libvpx could be impacted but it isn't working yet regardless)
> 
> 64bit libvpx on windows builds with the change to yasm_compile.gypi.

lgtm

[DaleCurtis, 2013-01-26 01:44:14]

https://codereview.chromium.org/12036108/diff/1/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/12036108/diff/1/media/media.gyp#newcode992
media/media.gyp:992: 'conditions': [
Instead of doing this, you could convert this target to use the yasm_compile
helper.

[jschuh, 2013-01-26 01:45:20]

On 2013/01/26 01:39:12, fgalligan1 wrote:
> 64bit libvpx on windows builds with the change to yasm_compile.gypi.

It doesn't build in Chrome Win64, most immediately because we're still missing
config/win/x64. The rest is hopefully a matter of suppressions in the short
term.

[Alpha Left Google, 2013-01-26 02:23:19]

On 2013/01/26 01:45:20, Justin Schuh wrote:
> On 2013/01/26 01:39:12, fgalligan1 wrote:
> > 64bit libvpx on windows builds with the change to yasm_compile.gypi.
> 
> It doesn't build in Chrome Win64, most immediately because we're still missing
> config/win/x64. The rest is hopefully a matter of suppressions in the short
> term.

I think you're talking about libvpx (for config/win/x64) which is not the
subject of concern in this patch.

Just this patch it lgtm.

[wolenetz, 2013-01-26 03:13:18]

Please review.  Are WIN32 or MSVC possibly necessary for building from VS IDE?

https://codereview.chromium.org/12036108/diff/1/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/12036108/diff/1/media/media.gyp#newcode992
media/media.gyp:992: 'conditions': [
On 2013/01/26 01:44:14, DaleCurtis wrote:
> Instead of doing this, you could convert this target to use the yasm_compile
> helper.

None of these are set (except PREFIX, incorrectly for win) in yasm_compile.gypi.
Unlike ffmpeg, in simd there is no config.asm for -DCHROMIUM or -DARCH_X86_64.
It appears -DWIN32 and -DMSVC are not required here.  I've built win64
yuv_convert_simd_x86 target, and for win32 I reran layout tests with minimal
failures.  See next PS.

[DaleCurtis, 2013-01-28 19:14:51]

lgtm

[Alpha Left Google, 2013-01-28 22:30:48]

lgtm again.

[fgalligan1, 2013-01-28 23:17:11]

lgtm

[commit-bot: I haz the power, 2013-01-29 00:08:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12036108/10002

[commit-bot: I haz the power, 2013-01-29 00:09:01]

Presubmit check for 12036108-10002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\) )?(2013|2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  media/base/simd/x86inc.asm

[wolenetz, 2013-01-29 00:12:47]

On 2013/01/29 00:09:01, I haz the power (commit-bot) wrote:
> Presubmit check for 12036108-10002 failed and returned exit status 1.
> 
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Warnings **
> License must match:
> .*? Copyright (\(c\) )?(2013|2012|2011|2010|2009|2008|2007|2006|2006-2008) The
> Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
> governed by a BSD-style license that can be\n.*? found in the LICENSE
file\.(?:
> \*/)?\n
> Found a bad license header in these files:
>   media/base/simd/x86inc.asm

The license has not changed.  How do I proceed here?

[scherkus (not reviewing), 2013-01-29 00:16:31]

On 2013/01/29 00:12:47, wolenetz wrote:
> On 2013/01/29 00:09:01, I haz the power (commit-bot) wrote:
> > Presubmit check for 12036108-10002 failed and returned exit status 1.
> > 
> > 
> > Running presubmit commit checks ...
> > 
> > ** Presubmit Warnings **
> > License must match:
> > .*? Copyright (\(c\) )?(2013|2012|2011|2010|2009|2008|2007|2006|2006-2008)
The
> > Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
> > governed by a BSD-style license that can be\n.*? found in the LICENSE
> file\.(?:
> > \*/)?\n
> > Found a bad license header in these files:
> >   media/base/simd/x86inc.asm
> 
> The license has not changed.  How do I proceed here?

Patch tools/checklicenses/checklicenses.py :)

[wolenetz, 2013-01-29 01:01:19]

On 2013/01/29 00:16:31, scherkus wrote:
> On 2013/01/29 00:12:47, wolenetz wrote:
> > On 2013/01/29 00:09:01, I haz the power (commit-bot) wrote:
> > > Presubmit check for 12036108-10002 failed and returned exit status 1.
> > > 
> > > 
> > > Running presubmit commit checks ...
> > > 
> > > ** Presubmit Warnings **
> > > License must match:
> > > .*? Copyright (\(c\) )?(2013|2012|2011|2010|2009|2008|2007|2006|2006-2008)
> The
> > > Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
> > > governed by a BSD-style license that can be\n.*? found in the LICENSE
> > file\.(?:
> > > \*/)?\n
> > > Found a bad license header in these files:
> > >   media/base/simd/x86inc.asm
> > 
> > The license has not changed.  How do I proceed here?
> 
> Patch tools/checklicenses/checklicenses.py :)

Thanks for your help.  tools/checklicenses/checklicenses.py is not failing.  It
looks like a whitelist entry needs to be added for the depot_tools
PanProjectChecks function in presubmit_canned_checks.py.

[DaleCurtis, 2013-01-29 19:11:37]

Committed manually as r179379 (presubmit successful).