Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 12036097: Disable profile shortcuts feature if --user-data-dir was specified. (Closed)

Created:
7 years, 11 months ago by Alexei Svitkine (slow)
Modified:
7 years, 11 months ago
Reviewers:
sail
CC:
chromium-reviews
Visibility:
Public.

Description

Disable profile shortcuts feature if --user-data-dir was specified. BUG=162021, 171794 TEST=Launching with --user-data-dir does provide profile shortcuts UI when creating/editing profiles and does not mess with any existing shortcuts. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
7 years, 11 months ago (2013-01-24 23:49:44 UTC) #1
sail
LGTM! Awesome.
7 years, 11 months ago (2013-01-25 00:13:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/12036097/1
7 years, 11 months ago (2013-01-25 00:41:10 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 04:56:06 UTC) #4
Message was sent while issue was closed.
Change committed as 178758

Powered by Google App Engine
This is Rietveld 408576698