Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 12036094: Fix crash on spell check "Ask Google for suggestions" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index 1888378a3538f3c3f5b8f965a34fe95b172f362b..57692fa8022f4f8d71b075604462ddbba1da8ede 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -94,6 +94,10 @@ gfx::Font NativeWidgetAura::GetWindowTitleFont() {
// NativeWidgetAura, internal::NativeWidgetPrivate implementation:
void NativeWidgetAura::InitNativeWidget(const Widget::InitParams& params) {
+ // Aura needs to know which desktop (Ash or regular) will manage this widget.
+ // See Widget::InitParams::context for details.
+ DCHECK(params.parent || params.context);
stevenjb 2013/01/24 23:32:33 nit: Since now at least two devs have been bitten
+
ownership_ = params.ownership;
window_->set_user_data(this);
« chrome/browser/ui/views/confirm_bubble_views_unittest.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698