Chromium Code Reviews
Help | Chromium Project | Sign in
(495)

Issue 12036074: overscroll: Enable overscroll navigation by default. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by sadrul
Modified:
1 year, 2 months ago
Reviewers:
sky, Jói
CC:
chromium-reviews_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, kuscher1
Visibility:
Public.

Description

overscroll: Enable overscroll navigation by default.

BUG=160668, 171777, 168873
TBR=joi@ for switch rename

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178643

Patch Set 1 : . #

Total comments: 1

Patch Set 2 : alternate #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : tot-merge #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Lint Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments ? errors Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments ? errors Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M content/browser/web_contents/navigation_controller_impl.cc View 1 2 3 3 chunks +6 lines, -4 lines 0 comments ? errors Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 1 2 3 1 chunk +7 lines, -1 line 0 comments ? errors Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 2 chunks +5 lines, -8 lines 0 comments ? errors Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments ? errors Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M content/public/common/content_switches.cc View 1 chunk +2 lines, -2 lines 1 comment ? errors Download
Trybot results:
Commit:

Messages

Total messages: 6
sadrul
https://codereview.chromium.org/12036074/diff/4001/content/browser/web_contents/navigation_controller_impl.cc File content/browser/web_contents/navigation_controller_impl.cc (left): https://codereview.chromium.org/12036074/diff/4001/content/browser/web_contents/navigation_controller_impl.cc#oldcode531 content/browser/web_contents/navigation_controller_impl.cc:531: << unique_id; Removed this because it makes the tests ...
1 year, 2 months ago #1
sadrul
+kuscher@ FYI
1 year, 2 months ago #2
sky
LGTM https://codereview.chromium.org/12036074/diff/9001/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (right): https://codereview.chromium.org/12036074/diff/9001/content/browser/web_contents/web_contents_view_aura.cc#newcode831 content/browser/web_contents/web_contents_view_aura.cc:831: web_contents_->GetDelegate()->CanOverscrollContent())) { nit: indent this line one more ...
1 year, 2 months ago #3
sadrul
Thanks! https://codereview.chromium.org/12036074/diff/9001/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (right): https://codereview.chromium.org/12036074/diff/9001/content/browser/web_contents/web_contents_view_aura.cc#newcode831 content/browser/web_contents/web_contents_view_aura.cc:831: web_contents_->GetDelegate()->CanOverscrollContent())) { On 2013/01/24 18:10:10, sky wrote: > ...
1 year, 2 months ago #4
sadrul
+joi@ for switch rename (content/public/) OWNERS TBR'ing
1 year, 2 months ago #5
Jói
1 year, 2 months ago #6
Message was sent while issue was closed.
LGTM for content/public, please address the nit below in a separate change (OK
to TBR to me).

https://codereview.chromium.org/12036074/diff/10003/content/public/common/con...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/12036074/diff/10003/content/public/common/con...
content/public/common/content_switches.cc:771: // Enables history navigation in
response to horizontal overscroll.
nit: Enables -> Disables
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6