Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 12036024: Fix the regex flatting html to prevent misdetection (Closed)

Created:
7 years, 11 months ago by Jói
Modified:
7 years, 11 months ago
Reviewers:
yoshiki
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Fix the regex flatting html to prevent misdetection In some case, the previous regex may mistake to detect a wrong part as a script/link tag. This patch fixes it. Landing for yoshiki@chromium.org, original patch at https://codereview.chromium.org/11953014/ Committed: https://code.google.com/p/grit-i18n/source/detail?r=104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M grit/format/html_inline.py View 1 chunk +2 lines, -2 lines 0 comments Download
M grit/format/html_inline_unittest.py View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jói
7 years, 11 months ago (2013-01-22 12:36:25 UTC) #1
Yoshiki, this is my patch-in of your patch.  Will land it TBR.  You will need to
close the original code review manually by pressing the X icon next to the issue
number at http://codereview.chromium.org/.

Cheers,
Jói

Powered by Google App Engine
This is Rietveld 408576698