Chromium Code Reviews
DescriptionSplit recursive Copy/Move into async tasks and support cross operation (in local case)
Also get cross-filesystem operation working
(as far as both belong to LocalFileSystemOperation).
(I'll make related clean-ups in follow-up patches later)
Similarly to dividing Remove change this basically makes
end-to-end recursive copy/move operation SLOW, while
concurrent tasks won't be blocked for a long time.
With config: 200 files, 120 dirs, 4-level tree, total 100MB
* Copy:
Before this change: Ave:164.01 msec, Stddev: 3.534 msec
After this change: Ave:228.34 msec, Stddev: 36.014 msec
* Move (copy+remove after this change):
Before this change: Ave: 87.76 msec, Stddev: 4.631 msec
After this change: Ave:392.12 msec, Stddev:35.340 msec
Patch from: https://codereview.chromium.org/12018017/
Try results: https://codereview.chromium.org/12051010/
BUG=110121, 146215
TEST=content_browsertests:FileSystemLayoutTest.{OpCopy,OpMove,CrossFilesystemOp}
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179128
Patch Set 1 : #Patch Set 2 : comment fix #Patch Set 3 : addressed eric's comment on 12051010 #
Total comments: 2
Patch Set 4 : addressed comments + leak fix merge #Patch Set 5 : rebase #Messages
Total messages: 4 (0 generated)
|