Initial work on ImageData.data.

Initial work on ImageData.data.

R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=17526

[blois, 2013-01-22 17:10:44]

https://codereview.chromium.org/12036013/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/12036013/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:12958: -  final Uint8ClampedArray data;
Might be good to keep the old version around (as either $dom_data or arrayData
w/ @deprecated).

Just to make sure that we don't break too much, as the workaround for
transferring image data is much slower after this change.

https://codereview.chromium.org/12036013/diff/1/tools/dom/scripts/systemnativ...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/12036013/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:283: if self._interface.id == 'ImageData' and
html_name == 'data':
Add a comment for this?

[Anton Muhin, 2013-01-23 08:38:21]

https://codereview.chromium.org/12036013/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/12036013/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:12958: -  final Uint8ClampedArray data;
I'd prefer not to keep to different, but very close APIs.

What about trying to land this and see how people will react?  If there are
compelling cases for posting canvas pixels, we'll have to roll this change out
until we have principled answer.  Otherwise, it might be just good enough (tm)

Do you know if people post pixel data a lot?  I myself do not know, the only
thing  I can speculate upon is it's impossible (apparently) to send those data
back, so I would be surprised to see people doing it a lot, but I might easily
be wrong.

On 2013/01/22 17:10:44, blois wrote:
> Might be good to keep the old version around (as either $dom_data or arrayData
> w/ @deprecated).
> 
> Just to make sure that we don't break too much, as the workaround for
> transferring image data is much slower after this change.

https://codereview.chromium.org/12036013/diff/1/tools/dom/scripts/systemnativ...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/12036013/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:283: if self._interface.id == 'ImageData' and
html_name == 'data':
On 2013/01/22 17:10:44, blois wrote:
> Add a comment for this?

Done.

[blois, 2013-01-23 16:56:04]

lgtm