Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12036003: Move window_open_disposition.h from webkit/ into ui/base. (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move window_open_disposition.h from webkit/ into ui/base. This reduces one more dependency on webkit from chrome. BUG=146251 R=jam@chromium.org,ben@chromium.org TBR=darin@chromium.org,tsepez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178082

Patch Set 1 #

Patch Set 2 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -121 lines) Patch
M chrome/browser/api/infobars/infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/command_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/command_updater_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/disposition_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/event_disposition.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/identity/web_auth_flow.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_instant_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_tabstrip.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/event_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_sub_menu_model_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/event_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/menu_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/location_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/other_device_menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/android/context_menu_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/automation_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/tab_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_location_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/page_navigator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/base/window_open_disposition.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ui.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/web_dialogs/web_dialog_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D webkit/glue/window_open_disposition.h View 1 chunk +0 lines, -23 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tfarina
7 years, 11 months ago (2013-01-21 00:52:33 UTC) #1
jam
lgtm, thanks
7 years, 11 months ago (2013-01-21 00:53:25 UTC) #2
tfarina
Ben, OWNERS approval for moving the file into ui/base/. Thanks,
7 years, 11 months ago (2013-01-21 00:56:23 UTC) #3
Ben Goodger (Google)
lgtm
7 years, 11 months ago (2013-01-22 17:29:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12036003/1
7 years, 11 months ago (2013-01-22 17:31:45 UTC) #5
commit-bot: I haz the power
Presubmit check for 12036003-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-22 17:32:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12036003/1
7 years, 11 months ago (2013-01-22 17:33:23 UTC) #7
jam
on behalf of tfarina, TBRing to darin for webkit and tsepez for the ipc file. ...
7 years, 11 months ago (2013-01-22 17:33:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12036003/15005
7 years, 11 months ago (2013-01-22 18:17:07 UTC) #9
jam
I need this change and it seems to be slowed down by flaky tests, so ...
7 years, 11 months ago (2013-01-22 20:44:01 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-22 20:49:30 UTC) #11

Powered by Google App Engine
This is Rietveld 408576698