Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: ui/gl/gl_egl_api_implementation.cc

Issue 1203513004: Respect the disabled extension list during binding initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: split extension binding loading from static binding loading; pass enabled extensions Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gl/gl_egl_api_implementation.h ('k') | ui/gl/gl_gl_api_implementation.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gl/gl_egl_api_implementation.h" 5 #include "ui/gl/gl_egl_api_implementation.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/strings/string_split.h" 8 #include "base/strings/string_split.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "ui/gl/gl_context.h" 10 #include "ui/gl/gl_context.h"
11 #include "ui/gl/gl_implementation.h" 11 #include "ui/gl/gl_implementation.h"
12 12
13 namespace gfx { 13 namespace gfx {
14 14
15 RealEGLApi* g_real_egl; 15 RealEGLApi* g_real_egl;
16 16
17 void InitializeStaticGLBindingsEGL() { 17 void InitializeStaticGLBindingsEGL() {
18 g_driver_egl.InitializeStaticBindings();
18 if (!g_real_egl) { 19 if (!g_real_egl) {
19 g_real_egl = new RealEGLApi(); 20 g_real_egl = new RealEGLApi();
20 } 21 }
21 g_real_egl->Initialize(&g_driver_egl); 22 g_real_egl->Initialize(&g_driver_egl);
22 g_current_egl_context = g_real_egl; 23 g_current_egl_context = g_real_egl;
23 g_driver_egl.InitializeStaticBindings(); 24 g_driver_egl.InitializeExtensionBindings(g_real_egl->GetEnabledExtensions());
24
25 g_real_egl->InitializeFilteredExtensions(); 25 g_real_egl->InitializeFilteredExtensions();
26 } 26 }
27 27
28 void InitializeDebugGLBindingsEGL() { 28 void InitializeDebugGLBindingsEGL() {
29 g_driver_egl.InitializeDebugBindings(); 29 g_driver_egl.InitializeDebugBindings();
30 } 30 }
31 31
32 void ClearGLBindingsEGL() { 32 void ClearGLBindingsEGL() {
33 if (g_real_egl) { 33 if (g_real_egl) {
34 delete g_real_egl; 34 delete g_real_egl;
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 } 107 }
108 } 108 }
109 109
110 const char* RealEGLApi::eglQueryStringFn(EGLDisplay dpy, EGLint name) { 110 const char* RealEGLApi::eglQueryStringFn(EGLDisplay dpy, EGLint name) {
111 if (!filtered_exts_.empty() && name == EGL_EXTENSIONS) { 111 if (!filtered_exts_.empty() && name == EGL_EXTENSIONS) {
112 return filtered_exts_.c_str(); 112 return filtered_exts_.c_str();
113 } 113 }
114 return EGLApiBase::eglQueryStringFn(dpy, name); 114 return EGLApiBase::eglQueryStringFn(dpy, name);
115 } 115 }
116 116
117 std::set<std::string> RealEGLApi::GetEnabledExtensions() const {
no sievers 2015/06/23 20:48:25 This is basically duplicated code, see InitializeF
118 std::set<std::string> enabled_extensions;
119
120 std::vector<std::string> platform_extensions_vec;
121 std::string platform_ext = DriverEGL::GetPlatformExtensions();
122 base::SplitString(platform_ext, ' ', &platform_extensions_vec);
123
124 std::vector<std::string> client_extensions_vec;
125 std::string client_ext = DriverEGL::GetClientExtensions();
126 base::SplitString(client_ext, ' ', &client_extensions_vec);
127
128 enabled_extensions.insert(platform_extensions_vec.begin(),
129 platform_extensions_vec.end());
130 enabled_extensions.insert(client_extensions_vec.begin(),
131 client_extensions_vec.end());
132
133 for (auto ext : disabled_exts_) {
134 enabled_extensions.erase(ext);
135 }
136
137 return enabled_extensions;
138 }
139
117 TraceEGLApi::~TraceEGLApi() { 140 TraceEGLApi::~TraceEGLApi() {
118 } 141 }
119 142
120 bool GetGLWindowSystemBindingInfoEGL(GLWindowSystemBindingInfo* info) { 143 bool GetGLWindowSystemBindingInfoEGL(GLWindowSystemBindingInfo* info) {
121 EGLDisplay display = eglGetCurrentDisplay(); 144 EGLDisplay display = eglGetCurrentDisplay();
122 const char* vendor = eglQueryString(display, EGL_VENDOR); 145 const char* vendor = eglQueryString(display, EGL_VENDOR);
123 const char* version = eglQueryString(display, EGL_VERSION); 146 const char* version = eglQueryString(display, EGL_VERSION);
124 const char* extensions = eglQueryString(display, EGL_EXTENSIONS); 147 const char* extensions = eglQueryString(display, EGL_EXTENSIONS);
125 *info = GLWindowSystemBindingInfo(); 148 *info = GLWindowSystemBindingInfo();
126 if (vendor) 149 if (vendor)
127 info->vendor = vendor; 150 info->vendor = vendor;
128 if (version) 151 if (version)
129 info->version = version; 152 info->version = version;
130 if (extensions) 153 if (extensions)
131 info->extensions = extensions; 154 info->extensions = extensions;
132 return true; 155 return true;
133 } 156 }
134 157
135 } // namespace gfx 158 } // namespace gfx
136 159
137 160
OLDNEW
« no previous file with comments | « ui/gl/gl_egl_api_implementation.h ('k') | ui/gl/gl_gl_api_implementation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698