Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1203513002: Use vmulq_n_u32(..., 0x01010101) to distribute alphas. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use vmulq_n_u32(..., 0x01010101) to distribute alphas. This seems to make alphas() faster and Load[24]Alphas() no slower. The change is particularly noticeable on xfermodes that call alphas() twice (on src and dst), with a 10-12% speedup. Xfermode_Difference_aa 29ms -> 28.4ms 0.98x Xfermode_DstATop_aa 27.2ms -> 26.7ms 0.98x Xfermode_Xor_aa 27.2ms -> 26.5ms 0.98x Xfermode_DstOver 23.6ms -> 22.9ms 0.97x Xfermode_DstOver_aa 27.8ms -> 26.8ms 0.96x Xfermode_DstOut 22.6ms -> 21.7ms 0.96x Xfermode_Multiply_aa 30ms -> 28.5ms 0.95x Xfermode_DstOut_aa 26.1ms -> 24.8ms 0.95x Xfermode_DstIn_aa 25.4ms -> 24.1ms 0.95x Xfermode_DstATop 28.7ms -> 26ms 0.9x Xfermode_Multiply 35.5ms -> 31.3ms 0.88x Xfermode_Difference 31.8ms -> 27.7ms 0.87x Xfermode_Xor 30.1ms -> 26.1ms 0.87x BUG=skia: Committed: https://skia.googlesource.com/skia/+/343c7d15c831a3c3d8a6984c1a1b524b414012df

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M src/opts/Sk4px_NEON.h View 1 chunk +14 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
5 years, 6 months ago (2015-06-22 17:54:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203513002/20001
5 years, 6 months ago (2015-06-22 17:55:31 UTC) #4
msarett
lgtm Nice! This is a clever!
5 years, 6 months ago (2015-06-22 17:58:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203513002/20001
5 years, 6 months ago (2015-06-22 18:00:15 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 18:00:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/343c7d15c831a3c3d8a6984c1a1b524b414012df

Powered by Google App Engine
This is Rietveld 408576698