Move client certificates retrieval logic out of the SSL sockets.

net/socket/socket_test_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/socket_test_util.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 1206 matching lines @@
   ssl_info->channel_id_sent = data_->channel_id_sent;
   return true;
 }
 
 void MockSSLClientSocket::GetSSLCertRequestInfo(
     SSLCertRequestInfo* cert_request_info) {
   DCHECK(cert_request_info);
   if (data_->cert_request_info) {
     cert_request_info->host_and_port =
         data_->cert_request_info->host_and_port;
-    cert_request_info->client_certs = data_->cert_request_info->client_certs;
-  } else {
-    cert_request_info->Reset();
   }

[Ryan Sleevi, 2013/01/29 19:59:49]

BUG: This change is not correct:
1) You should match what the socket's are doing, which is to Reset() the request
info
2) You should be providing the authorities (as part of a pass-thru), so that we
can properly mock SSL client auth without requiring a real socket.

[This was originally added back in http://crrev.com/71071 . It looks like that
particular test added was removed when we removed false start, but I want to
make sure this change isn't breaking the test bits. Of course, we may just
remove the test bits in a follow-up]

[ppi, 2013/01/30 15:34:56]

I see, thanks. Reverted in patch set 4. We will probably revisit this code soon,
e.g. when we remove |client_certs| from SSLCertRequestInfo.

 }
 
 SSLClientSocket::NextProtoStatus MockSSLClientSocket::GetNextProto(
     std::string* proto, std::string* server_protos) {
   *proto = data_->next_proto;
   *server_protos = data_->server_protos;
   return data_->next_proto_status;
 }
 
 bool MockSSLClientSocket::set_was_npn_negotiated(bool negotiated) {
@@ skipping 465 matching lines @@
 
 const char kSOCKS5OkRequest[] =
     { 0x05, 0x01, 0x00, 0x03, 0x04, 'h', 'o', 's', 't', 0x00, 0x50 };
 const int kSOCKS5OkRequestLength = arraysize(kSOCKS5OkRequest);
 
 const char kSOCKS5OkResponse[] =
     { 0x05, 0x00, 0x00, 0x01, 127, 0, 0, 1, 0x00, 0x50 };
 const int kSOCKS5OkResponseLength = arraysize(kSOCKS5OkResponse);
 
 }  // namespace net