net/data/ssl/scripts/client_authentication/run-test-server.sh - Issue 12035105: Move client certificates retrieval logic out of the SSL sockets.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/ssl/scripts/client_authentication/run-test-server.sh

Issue 12035105: Move client certificates retrieval logic out of the SSL sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Linux Redux build Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/loader/resource_loader.cc ('K') | « net/data/ssl/scripts/client_authentication/generate-client-certificates.sh ('k') | net/http/http_network_transaction.cc » ('j') | net/socket/socket_test_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 #!/bin/bash

	2

	3 # Helper script for local manual testing. Runs an openssl test server at

	4 # localhost:4433. The server will be accessible for www connections and will

	5 # require a client certificate issued by Client Auth Test Root 1.

	6 openssl s_server \

	7 -accept 4433 \

	8 -cert out/root_1.pem \

	9 -key out/root_1.key \

	10 -www \

	11 -Verify 5 \

	12 -CAfile out/root_1.pem
	Ryan Sleevi 2013/01/29 19:59:49 For checking in, this should be a 'real' test usin For checking in, this should be a 'real' test using TestServer. Simply having this script has no guarantees that it won't get broken in the future, so I'm not sure it helps anyone. ppi 2013/01/30 15:34:56 This is just a tiny helper that I thought could be Show quoted text On 2013/01/29 19:59:49, Ryan Sleevi wrote: > For checking in, this should be a 'real' test using TestServer. Simply having > this script has no guarantees that it won't get broken in the future, so I'm not > sure it helps anyone. This is just a tiny helper that I thought could be helpful to anyone willing to manually test client authentication in Chrome (certainly such script would be helpful to me if we had it before). That being said, I agree that it is at least optional if not redundant - please let me know if you would like it out of the patch set.
OLD	NEW