Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 12035079: Fix braino that lead to dead code that contained a typo. Also add a regression test. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/interceptor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 17558)
+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)
@@ -722,7 +722,7 @@
HInstruction visitOneShotInterceptor(HOneShotInterceptor node) {
HInstruction newInstruction = handleInterceptorCall(node);
- if (newInstruction != null) return newInstruction;
+ if (newInstruction != node) return newInstruction;
HInstruction constant = tryComputeConstantInterceptor(
node.inputs[1], node.interceptedClasses);
@@ -735,12 +735,12 @@
if (selector.isGetter()) {
HInstruction res = new HInvokeDynamicGetter(
selector, node.element, constant, false);
- res.inputs.add(node.intputs[1]);
+ res.inputs.add(node.inputs[1]);
return res;
} else if (node.selector.isSetter()) {
HInstruction res = new HInvokeDynamicSetter(
selector, node.element, constant, node.inputs[1], false);
- res.inputs.add(node.intputs[2]);
+ res.inputs.add(node.inputs[2]);
return res;
} else {
List<HInstruction> inputs = new List<HInstruction>.from(node.inputs);
« no previous file with comments | « no previous file | tests/compiler/dart2js/interceptor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698