IDL generated extensions code only generate foo_api.h when required

IDL generated extensions code only generate foo_api.h when required

BUG=148545
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178751

[calamity, 2013-01-24 05:15:03]

Tested by adding a dummy idl without its corresponding api file.

[koz (OOO until 15th September), 2013-01-24 05:20:15]

I think kalman would be a better reviewer for this.

[not at google - send to devlin, 2013-01-24 06:44:24]

lgtm

https://codereview.chromium.org/12035070/diff/1/tools/json_schema_compiler/sc...
File tools/json_schema_compiler/schema_bundle_generator.py (right):

https://codereview.chromium.org/12035070/diff/1/tools/json_schema_compiler/sc...
tools/json_schema_compiler/schema_bundle_generator.py:78:
os.path.join(self._root, os.path.normpath(implementation_header))):
prefer to invert condition and continue here instead

[not at google - send to devlin, 2013-01-24 22:36:26]

https://codereview.chromium.org/12035070/diff/1/tools/json_schema_compiler/sc...
File tools/json_schema_compiler/schema_bundle_generator.py (right):

https://codereview.chromium.org/12035070/diff/1/tools/json_schema_compiler/sc...
tools/json_schema_compiler/schema_bundle_generator.py:78:
os.path.join(self._root, os.path.normpath(implementation_header))):
On 2013/01/24 06:44:24, kalman wrote:
> prefer to invert condition and continue here instead

Another thing - we should throw an error if the path wasn't found but if
implementation_header was specified in compiler options. That would indicate a
bug.

[calamity, 2013-01-24 23:25:55]

https://codereview.chromium.org/12035070/diff/1/tools/json_schema_compiler/sc...
File tools/json_schema_compiler/schema_bundle_generator.py (right):

https://codereview.chromium.org/12035070/diff/1/tools/json_schema_compiler/sc...
tools/json_schema_compiler/schema_bundle_generator.py:78:
os.path.join(self._root, os.path.normpath(implementation_header))):
On 2013/01/24 22:36:26, kalman wrote:
> On 2013/01/24 06:44:24, kalman wrote:
> > prefer to invert condition and continue here instead
> 
> Another thing - we should throw an error if the path wasn't found but if
> implementation_header was specified in compiler options. That would indicate a
> bug.

Done.

[not at google - send to devlin, 2013-01-24 23:29:00]

https://codereview.chromium.org/12035070/diff/7001/tools/json_schema_compiler...
File tools/json_schema_compiler/schema_bundle_generator.py (right):

https://codereview.chromium.org/12035070/diff/7001/tools/json_schema_compiler...
tools/json_schema_compiler/schema_bundle_generator.py:87: continue
I preferred it the way it was. Logic here would be

if not os.path.exists(...):
  if 'implementation_header' in namespace.compiler_options:
    raise ValueError(...)
  continue

note that the else: branch is unnecessary since raising an error is effectively
a return statement.

[calamity, 2013-01-24 23:37:43]

https://codereview.chromium.org/12035070/diff/7001/tools/json_schema_compiler...
File tools/json_schema_compiler/schema_bundle_generator.py (right):

https://codereview.chromium.org/12035070/diff/7001/tools/json_schema_compiler...
tools/json_schema_compiler/schema_bundle_generator.py:87: continue
On 2013/01/24 23:29:00, kalman wrote:
> I preferred it the way it was. Logic here would be
> 
> if not os.path.exists(...):
>   if 'implementation_header' in namespace.compiler_options:
>     raise ValueError(...)
>   continue
> 
> note that the else: branch is unnecessary since raising an error is
effectively
> a return statement.

Done.

[commit-bot: I haz the power, 2013-01-25 02:08:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/12035070/5002

[commit-bot: I haz the power, 2013-01-25 04:49:11]

Change committed as 178751