Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: utils/apidoc/html_diff.dart

Issue 12035057: First half of the new HTML json docs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed unneeded file. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/html_json_doc/lib/html_to_json.dart ('k') | utils/apidoc/lib/metadata.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/apidoc/html_diff.dart
diff --git a/utils/apidoc/html_diff.dart b/utils/apidoc/html_diff.dart
index 776ed1a37cb82c7133cdd4615260b2ba06023bab..e25174553474983a62b7340ac7299a8df8f1d204 100644
--- a/utils/apidoc/html_diff.dart
+++ b/utils/apidoc/html_diff.dart
@@ -11,6 +11,7 @@ library html_diff;
import 'dart:io';
import 'dart:async';
import '../../sdk/lib/html/html_common/metadata.dart';
+import 'lib/metadata.dart';
// TODO(rnystrom): Use "package:" URL (#4968).
import '../../sdk/lib/_internal/dartdoc/lib/dartdoc.dart';
@@ -152,7 +153,7 @@ class HtmlDiff {
List<String> htmlToDomTypes(ClassMirror htmlType) {
if (htmlType.simpleName == null) return <String>[];
- final domNameMetadata = _findMetadata(htmlType.metadata, 'DomName');
+ final domNameMetadata = findMetadata(htmlType.metadata, 'DomName');
if (domNameMetadata != null) {
var domNames = <String>[];
var tags = deprecatedFutureValue(domNameMetadata.getField('name'));
@@ -176,7 +177,7 @@ class HtmlDiff {
Set<String> htmlToDomMembers(MemberMirror htmlMember, List<String> domTypes) {
if (htmlMember.isPrivate) return new Set();
- final domNameMetadata = _findMetadata(htmlMember.metadata, 'DomName');
+ final domNameMetadata = findMetadata(htmlMember.metadata, 'DomName');
if (domNameMetadata != null) {
var domNames = <String>[];
var tags = deprecatedFutureValue(domNameMetadata.getField('name'));
@@ -233,12 +234,4 @@ class HtmlDiff {
}
return new Set.from([name]);
}
-
-}
-
-/// Returns the metadata for the given string or null if not found.
-InstanceMirror _findMetadata(List<InstanceMirror> metadataList, String find) {
- return metadataList.firstMatching(
- (metadata) => metadata.type.simpleName == find,
- orElse: () => null);
-}
+}
« no previous file with comments | « tools/html_json_doc/lib/html_to_json.dart ('k') | utils/apidoc/lib/metadata.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698