Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 12035052: Added a comment to clarify the interpretation of exit codes on windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index b78d6d7cd22cad36c41d7a16debae632c2e641f0..a3e72c9712e24773ba8dad225a2e838761785d58 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -566,6 +566,12 @@ class CommandOutputImpl implements CommandOutput {
if (exitCode == 3) {
return !timedOut;
}
+ // If a program receives an uncaught system exception, the program
+ // terminates with the exception code as exit code.
+ // The 0x3FFFFF00 mask here tries to determine if an exception indicates
+ // a crash of the program.
+ // System exception codes can be found in 'winnt.h', for example
+ // "#define STATUS_ACCESS_VIOLATION ((DWORD) 0xC0000005)"
return (!timedOut && (exitCode < 0) && ((0x3FFFFF00 & exitCode) == 0));
}
return !timedOut && ((exitCode < 0));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698