Implementing app command to query EULA acceptance state for Chrome.

chrome/installer/util/eula_util.h

Index: chrome/installer/util/eula_util.h
diff --git a/chrome/installer/util/eula_util.h b/chrome/installer/util/eula_util.h
new file mode 100755
index 0000000000000000000000000000000000000000..0f40080d85a50aa17fb9a325a47dd4a9e161b486
--- /dev/null
+++ b/chrome/installer/util/eula_util.h
@@ -0,0 +1,20 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// This file contains utilities to read and manage EULA for Chrome.

[grt (UTC plus 2), 2013/01/24 02:51:40]

i think it's more accurate to say something about the file containing helper
functions relating to Chrome's EULA. as it is, the comment implies that there's
a utility to read the EULA.

[huangs, 2013/01/24 18:56:03]

Done.

+
+#ifndef CHROME_INSTALLER_UTIL_EULA_UTIL_H_
+#define CHROME_INSTALLER_UTIL_EULA_UTIL_H_
+
+#include <windows.h>
+
+namespace installer {
+
+// Performs a comprehensive test on EULA acceptance in Chrome.

[grt (UTC plus 2), 2013/01/24 02:51:40]

"...in system-level Chrome."

[huangs, 2013/01/24 18:56:03]

Done (more elaborate comments).

+// Returns: 0 if EULA not accepted, 1 if EULA accepted, and E_FAIL on error.

[grt (UTC plus 2), 2013/01/24 02:51:40]

you're mixing windows HRESULTS with arbitrary values you've picked. please don't
do this. either use HRESULTS consistently (e.g., S_FALSE, S_OK, or E_FAIL), or
make up your own type. fwiw, i don't see an obvious benefit to using HRESULT
here (except if you're coding with malice :-)). using your own enum will add
clarity to the code.

[huangs, 2013/01/24 18:56:03]

Defined enum EULAAcceptanceResponse.  Is it okay that it gets implicitly casted
to int, and returned as exit code?

[grt (UTC plus 2), 2013/01/24 21:04:55]

IIRC, a process exit code in Windows is a DWORD, which is unsigned. I don't
think you should be returning -1 from your process. For consistency with
ordinary process exit, I think you should try to make 0 represent the thumbs-up
success case, and other non-zero values represent the other cases.

+HRESULT IsEULAAccepted();
+
+}  // namespace installer
+
+#endif  // CHROME_INSTALLER_UTIL_EULA_UTIL_H_