Implementing app command to query EULA acceptance state for Chrome.

chrome/installer/setup/install_worker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the definitions of the installer functions that build
 // the WorkItemList used to install the application.
 
 #include "chrome/installer/setup/install_worker.h"
 
 #include <oaidl.h>
@@ skipping 194 matching lines @@
                                         archive_dst.value(),
                                         temp_path.value(),
                                         WorkItem::ALWAYS);
 #endif  // COMPONENT_BUILD
     }
   }
 }
 
 void AddInstallAppCommandWorkItems(const InstallerState& installer_state,
                                    const InstallationState& machine_state,
-                                   const FilePath& setup_path,

[huangs, 2013/01/23 04:37:56]

(Unrelated) code cleanup: unused parameter.

                                    const Version& new_version,
                                    const Product& product,
                                    WorkItemList* work_item_list) {
   DCHECK(product.is_chrome_app_host());
 
   string16 cmd_key(product.distribution()->GetVersionKey());
   cmd_key.append(1, L'\\').append(google_update::kRegCommandsKey)
       .append(1, L'\\').append(kCmdInstallApp);
 
   if (installer_state.operation() == InstallerState::UNINSTALL) {
@@ skipping 20 matching lines @@
   const Products& products = installer_state.products();
   for (Products::const_iterator it = products.begin(); it < products.end();
        ++it) {
     const Product& p = **it;
     if (p.is_chrome_frame()) {
       AddChromeFrameWorkItems(original_state, installer_state, setup_path,
                               new_version, p, list);
     }
     if (p.is_chrome_app_host()) {
       AddInstallAppCommandWorkItems(installer_state, original_state,
-                                    setup_path, new_version, p, list);

[huangs, 2013/01/23 04:37:56]

(Unrelated) code cleanup: unused parameter.

+                                    new_version, p, list);
+      AddQueryEULAAcceptanceWorkItems(installer_state, p, list);
     }
     if (p.is_chrome()) {
       AddOsUpgradeWorkItems(installer_state, setup_path, new_version, p,
                             list);
     }
   }
 }
 
 // This is called when an MSI installation is run. It may be that a user is
 // attempting to install the MSI on top of a non-MSI managed installation.
@@ skipping 1363 matching lines @@
       cmd_line.AppendSwitch(installer::switches::kSystemLevel);
     // Log everything for now.
     cmd_line.AppendSwitch(installer::switches::kVerboseLogging);
 
     AppCommand cmd(cmd_line.GetCommandLineString());
     cmd.set_is_auto_run_on_os_upgrade(true);
     cmd.AddWorkItems(installer_state.root_key(), cmd_key, install_list);
   }
 }
 
+void AddQueryEULAAcceptanceWorkItems(const InstallerState& installer_state,
+                                     const Product& product,
+                                     WorkItemList* work_item_list) {
+  const HKEY root_key = installer_state.root_key();
+  string16 cmd_key(product.distribution()->GetVersionKey());

[grt (UTC plus 2), 2013/01/23 19:02:29]

this is adding the command to the app host.  something here doesn't seem right.
should it be invoking the system-level chrome.exe?

[huangs, 2013/01/24 00:08:08]

It's invoking whatever Chrome that's available.

+  cmd_key.append(1, FilePath::kSeparators[0])
+      .append(google_update::kRegCommandsKey)
+      .append(1, FilePath::kSeparators[0])
+      .append(kCmdQueryEULAAcceptance);
+  if (installer_state.operation() == InstallerState::UNINSTALL) {
+    work_item_list->AddDeleteRegKeyWorkItem(root_key, cmd_key)->
+        set_log_message("Removing query EULA acceptance command");
+  } else {
+    CommandLine cmd_line(
+        installer_state.target_path().Append(installer::kChromeAppHostExe));

[grt (UTC plus 2), 2013/01/23 19:02:29]

kChromeAppHostExe -> kChromeExe?

[huangs, 2013/01/24 00:08:08]

Done.

+    cmd_line.AppendSwitch(::switches::kQueryEULAAcceptance);
+    AppCommand cmd(cmd_line.GetCommandLineString());
+    // cmd.set_sends_pings(true);   // QUESTION(huangs): Do we need this?????

[huangs, 2013/01/23 04:37:56]

Please note question.

+    cmd.set_is_web_accessible(true);
+    cmd.AddWorkItems(installer_state.root_key(), cmd_key, work_item_list);
+  }
+}
+
 }  // namespace installer