[DevTools] Implement screen size and position in Emulation.setDeviceMetricsOverrides.

[DevTools] Implement screen size and position in Emulation.setDeviceMetricsOverrides.

BUG=393493
Committed: https://crrev.com/f28ccbe24a728b531b451fbcacba3d5edb1e5cd8
Cr-Commit-Position: refs/heads/master@{#335888}

[dgozman, 2015-06-22 17:02:02]

dgozman@chromium.org changed reviewers:
+ jochen@chromium.org, nasko@chromium.org, pfeldman@chromium.org

[dgozman, 2015-06-22 17:02:03]

Could you please take a look?

Pavel - at everything.
Nasko - at view_messsages.
Jochen - at render_widget.

Thanks,
Dmitry

[pfeldman, 2015-06-22 17:51:26]

lgtm

[nasko, 2015-06-23 10:44:44]

https://codereview.chromium.org/1203503002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/emulation_handler.cc (right):

https://codereview.chromium.org/1203503002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/emulation_handler.cc:128: int width, int
height, double device_scale_factor, bool mobile,
nit: All parameters should be on a new line.

https://codereview.chromium.org/1203503002/diff/1/content/common/view_messages.h
File content/common/view_messages.h (right):

https://codereview.chromium.org/1203503002/diff/1/content/common/view_message...
content/common/view_messages.h:161: IPC_STRUCT_TRAITS_MEMBER(screenSize)
Is there a blink CL that is adding these members?

[dgozman, 2015-06-23 12:00:56]

https://codereview.chromium.org/1203503002/diff/1/content/common/view_messages.h
File content/common/view_messages.h (right):

https://codereview.chromium.org/1203503002/diff/1/content/common/view_message...
content/common/view_messages.h:161: IPC_STRUCT_TRAITS_MEMBER(screenSize)
On 2015/06/23 10:44:44, nasko (paris) wrote:
> Is there a blink CL that is adding these members?

Sure, it's already committed: https://codereview.chromium.org/1202523003/.

[dgozman, 2015-06-23 12:03:15]

PTAL

https://codereview.chromium.org/1203503002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/emulation_handler.cc (right):

https://codereview.chromium.org/1203503002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/emulation_handler.cc:128: int width, int
height, double device_scale_factor, bool mobile,
On 2015/06/23 10:44:44, nasko (paris) wrote:
> nit: All parameters should be on a new line.

Done.

[nasko, 2015-06-23 12:12:55]

LGTM

[jochen (gone - plz use gerrit), 2015-06-23 14:59:47]

lgtm with nit

https://codereview.chromium.org/1203503002/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/emulation_handler.cc (right):

https://codereview.chromium.org/1203503002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/emulation_handler.cc:128: int width,
wouldn't clang format put as many parameters as possible on one line?

[dgozman, 2015-06-23 15:05:24]

https://codereview.chromium.org/1203503002/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/emulation_handler.cc (right):

https://codereview.chromium.org/1203503002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/emulation_handler.cc:128: int width,
On 2015/06/23 14:59:47, jochen wrote:
> wouldn't clang format put as many parameters as possible on one line?

I've just changed to one-per-line per nasko@ comment. Seems like
http://dev.chromium.org/developers/coding-style insists on one per line in
function definition.

[dgozman, 2015-06-23 15:31:17]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-06-23 15:31:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1203503002/#ps20001
(title: "Fixed nit")

[commit-bot: I haz the power, 2015-06-23 15:33:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1203503002/20001

[commit-bot: I haz the power, 2015-06-23 16:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 16:22:01]

Exceeded global retry quota

[dgozman, 2015-06-23 16:30:45]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-06-23 16:34:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1203503002/20001

[commit-bot: I haz the power, 2015-06-23 16:52:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 16:52:46]

Exceeded global retry quota

[dgozman, 2015-06-24 08:45:47]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-06-24 08:46:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1203503002/20001

[commit-bot: I haz the power, 2015-06-24 08:51:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-24 08:52:00]

Patchset 2 (id:??) landed as
https://crrev.com/f28ccbe24a728b531b451fbcacba3d5edb1e5cd8
Cr-Commit-Position: refs/heads/master@{#335888}