Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditDiffViewer.java

Issue 12035015: Disaply compile error position in diff viewer (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: fcr Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditDiffViewer.java
diff --git a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditDiffViewer.java b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditDiffViewer.java
index 3f7a6b6d5c4e8601af9848817a07e56cdda5381b..452f6fb7fdeedf75cfe32190d432b06ebdbb8d05 100644
--- a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditDiffViewer.java
+++ b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditDiffViewer.java
@@ -351,15 +351,11 @@ public class LiveEditDiffViewer {
if (position == null) {
return "."; //$NON-NLS-1$
} else {
- if (functionNode.getParent() == null) {
- return Messages.LiveEditDiffViewer_SCRIPT;
+ String name = functionNode.getName();
+ if (name == null || name.trim().length() == 0) {
+ return Messages.LiveEditDiffViewer_UNNAMED;
} else {
- String name = functionNode.getName();
- if (name == null || name.trim().length() == 0) {
- return Messages.LiveEditDiffViewer_UNNAMED;
- } else {
- return name;
- }
+ return name;
}
}
}
« no previous file with comments | « no previous file | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698