Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/bots/compiler.py

Issue 12035004: Add support for having both 10.8 and 10.7 mac bots side by side on the buildbot waterfall (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py (revision 17333)
+++ tools/bots/compiler.py (working copy)
@@ -22,7 +22,7 @@
DART2JS_BUILDER = (
r'dart2js-(linux|mac|windows)(-(jsshell))?-(debug|release)(-(checked|host-checked))?(-(host-checked))?(-(minified))?-?(\d*)-?(\d*)')
WEB_BUILDER = (
- r'dart2js-(ie9|ie10|ff|safari|chrome|opera)-(win7|win8|mac|linux)(-(all|html))?(-(\d+)-(\d+))?')
+ r'dart2js-(ie9|ie10|ff|safari|chrome|opera)-(win7|win8|mac10\.8|mac10\.7|linux)(-(all|html))?(-(\d+)-(\d+))?')
Lasse Reichstein Nielsen 2013/01/21 08:02:00 mac10\.[78]
def GetBuildInfo(builder_name, is_buildbot):
@@ -79,13 +79,16 @@
if system == 'windows':
system = 'win7'
+ # We have both 10.8 and 10.7 bots, functionality is the same.
+ if system == 'mac10.8' or system == 'mac10.7':
Lasse Reichstein Nielsen 2013/01/21 08:02:00 Is there a "startsWith" so you can just check if i
+ system = 'mac'
+
if (system == 'win7' and platform.system() != 'Windows') or (
system == 'mac' and platform.system() != 'Darwin') or (
system == 'linux' and platform.system() != 'Linux'):
print ('Error: You cannot emulate a buildbot with a platform different '
'from your own.')
return None
-
return bot.BuildInfo(compiler, runtime, mode, system, checked, host_checked,
minified, shard_index, total_shards, is_buildbot,
test_set)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698