[tracing] Adding class-wise memory statistics to blink gc memory dumps

Source/platform/heap/Heap.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 224 matching lines @@
 
     ASSERT(!m_firstUnsweptPage);
     // Add the BaseHeap's pages to the orphanedPagePool.
     for (BasePage* page = m_firstPage; page; page = page->next()) {
         Heap::decreaseAllocatedSpace(page->size());
         Heap::orphanedPagePool()->addOrphanedPage(heapIndex(), page);
     }
     m_firstPage = nullptr;
 }
 
-void BaseHeap::takeSnapshot(const String& dumpBaseName)
+void BaseHeap::takeSnapshot(const String& dumpBaseName, ThreadState::GCSnapshotInfo& info)
 {
     // |dumpBaseName| at this point is "blink_gc/thread_X/heaps/HeapName"
     WebMemoryAllocatorDump* allocatorDump = BlinkGCMemoryDumpProvider::instance()->createMemoryAllocatorDumpForCurrentGC(dumpBaseName);
     size_t pageIndex = 0;
     size_t heapTotalFreeSize = 0;
     size_t heapTotalFreeCount = 0;
     for (BasePage* page = m_firstUnsweptPage; page; page = page->next()) {
         size_t heapPageFreeSize = 0;
         size_t heapPageFreeCount = 0;
-        page->takeSnapshot(dumpBaseName, pageIndex, &heapPageFreeSize, &heapPageFreeCount);
+        page->takeSnapshot(dumpBaseName, pageIndex, info, &heapPageFreeSize, &heapPageFreeCount);
         heapTotalFreeSize += heapPageFreeSize;
         heapTotalFreeCount += heapPageFreeCount;
         pageIndex++;
     }
     allocatorDump->AddScalar("blink_page_count", "objects", pageIndex);
 
     // When taking a full dump (w/ freelist), both the /buckets and /pages
     // report their free size but they are not meant to be added together.
     // Therefore, here we override the free_size of the parent heap to be
     // equal to the free_size of the sum of its heap pages.
@@ skipping 1282 matching lines @@
     // cross thread pointer usage.
 #if defined(ADDRESS_SANITIZER)
     // This needs to zap poisoned memory as well.
     // Force unpoison memory before memset.
     ASAN_UNPOISON_MEMORY_REGION(payload(), payloadSize());
 #endif
     OrphanedPagePool::asanDisabledMemset(payload(), OrphanedPagePool::orphanedZapValue, payloadSize());
     BasePage::markOrphaned();
 }
 
-void NormalPage::takeSnapshot(String dumpName, size_t pageIndex, size_t* outFreeSize, size_t* outFreeCount)
+void NormalPage::takeSnapshot(String dumpName, size_t pageIndex, ThreadState::GCSnapshotInfo& info, size_t* outFreeSize, size_t* outFreeCount)
 {
     dumpName.append(String::format("/pages/page_%lu", static_cast<unsigned long>(pageIndex)));
     WebMemoryAllocatorDump* pageDump = BlinkGCMemoryDumpProvider::instance()->createMemoryAllocatorDumpForCurrentGC(dumpName);
 
     HeapObjectHeader* header = nullptr;
     size_t liveCount = 0;
     size_t deadCount = 0;
     size_t freeCount = 0;
     size_t liveSize = 0;
     size_t deadSize = 0;
     size_t freeSize = 0;
     for (Address headerAddress = payload(); headerAddress < payloadEnd(); headerAddress += header->size()) {
         header = reinterpret_cast<HeapObjectHeader*>(headerAddress);
         if (header->isFree()) {
             freeCount++;
             freeSize += header->size();
         } else if (header->isMarked()) {
             liveCount++;
             liveSize += header->size();
+
+            size_t tag = header->gcInfoIndex();

[haraken, 2015/08/10 23:54:48]

tag => gcInfoIndex

[ssid, 2015/08/11 09:03:03]

Done.

+            info.liveCount[tag]++;
+            info.liveSize[tag] += header->size();
         } else {
             deadCount++;
             deadSize += header->size();
+
+            size_t tag = header->gcInfoIndex();

[haraken, 2015/08/10 23:54:48]

Ditto.

+            info.deadCount[tag]++;
+            info.deadSize[tag] += header->size();
         }
     }
 
     pageDump->AddScalar("live_count", "objects", liveCount);
     pageDump->AddScalar("dead_count", "objects", deadCount);
     pageDump->AddScalar("free_count", "objects", freeCount);
     pageDump->AddScalar("live_size", "bytes", liveSize);
     pageDump->AddScalar("dead_size", "bytes", deadSize);
     pageDump->AddScalar("free_size", "bytes", freeSize);
     *outFreeSize = freeSize;
@@ skipping 168 matching lines @@
 }
 
 void LargeObjectPage::markOrphaned()
 {
     // Zap the payload with a recognizable value to detect any incorrect
     // cross thread pointer usage.
     OrphanedPagePool::asanDisabledMemset(payload(), OrphanedPagePool::orphanedZapValue, payloadSize());
     BasePage::markOrphaned();
 }
 
-void LargeObjectPage::takeSnapshot(String dumpName, size_t pageIndex, size_t* outFreeSize, size_t* outFreeCount)
+void LargeObjectPage::takeSnapshot(String dumpName, size_t pageIndex, ThreadState::GCSnapshotInfo& info, size_t* outFreeSize, size_t* outFreeCount)
 {
     dumpName.append(String::format("/pages/page_%lu", static_cast<unsigned long>(pageIndex)));
     WebMemoryAllocatorDump* pageDump = BlinkGCMemoryDumpProvider::instance()->createMemoryAllocatorDumpForCurrentGC(dumpName);
 
     size_t liveSize = 0;
     size_t deadSize = 0;
     size_t liveCount = 0;
     size_t deadCount = 0;
     HeapObjectHeader* header = heapObjectHeader();
+    size_t tag = header->gcInfoIndex();

[haraken, 2015/08/10 23:54:48]

Ditto.

[ssid, 2015/08/11 09:03:03]

Done.

     if (header->isMarked()) {
         liveCount = 1;
         liveSize += header->payloadSize();
+        info.liveCount[tag]++;
+        info.liveSize[tag] += header->size();

[haraken, 2015/08/10 23:54:48]

Yeah, it is inconsistent we mix header->size() and header->payloadSize(). I
think we should use header->size() at line 1790 but it's ok to leave it as is in
this CL. I'll fix in a follow-up.

[ssid, 2015/08/11 09:03:03]

Sorry, I keep getting confused between these two. I am leaving it as size(),
Thanks.

     } else {
         deadCount = 1;
         deadSize += header->payloadSize();
+        info.deadCount[tag]++;
+        info.deadSize[tag] += header->size();
     }
 
     pageDump->AddScalar("live_count", "objects", liveCount);
     pageDump->AddScalar("dead_count", "objects", deadCount);
     pageDump->AddScalar("live_size", "bytes", liveSize);
     pageDump->AddScalar("dead_size", "bytes", deadSize);
 }
 
 #if ENABLE(GC_PROFILING)
 const GCInfo* LargeObjectPage::findGCInfo(Address address)
@@ skipping 740 matching lines @@
 size_t Heap::s_objectSizeAtLastGC = 0;
 size_t Heap::s_markedObjectSize = 0;
 size_t Heap::s_persistentCount = 0;
 size_t Heap::s_persistentCountAtLastGC = 0;
 size_t Heap::s_collectedPersistentCount = 0;
 size_t Heap::s_partitionAllocSizeAtLastGC = 0;
 size_t Heap::s_heapSizePerPersistent = 0;
 double Heap::s_estimatedMarkingTimePerByte = 0.0;
 
 } // namespace blink