Issue 1203443007: Prettier arrows in the stock app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1203443007: Prettier arrows in the stock app. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
hansmuller1, eseidel

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Prettier arrows in the stock app. This returns us to a more stocks1-like arrow style. Also it uses math rather than transforms to rotate the arrow, since transforms are expensive. It also removes the save/restore calls, which are _really_ expensive. Also some minor style fixes. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b857f2fd26ad82b504a9214d7157d2158341a4c3

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -23 lines)			Patch
	M	sky/examples/stocks2/lib/stock_arrow.dart	View		1 chunk	+23 lines, -23 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-23 00:32:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b857f2fd26ad82b504a9214d7157d2158341a4c3 (presubmit successful).