Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1900)

Unified Diff: tools/skp/page_sets/skia_googlehome_desktop.py

Issue 1203433002: Migrate PageSets to StorySets in buildbot page sets (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Fix typo Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/skp/page_sets/skia_googlehome_desktop.py
diff --git a/tools/skp/page_sets/skia_googlehome_desktop.py b/tools/skp/page_sets/skia_googlehome_desktop.py
index ab7a7abd54b96b314c8b0a234e90997d8d1e10c6..4f75fe2b1b70ad10d385d36b652afcc33c7a5bc7 100644
--- a/tools/skp/page_sets/skia_googlehome_desktop.py
+++ b/tools/skp/page_sets/skia_googlehome_desktop.py
@@ -4,8 +4,9 @@
# pylint: disable=W0401,W0614
+from telemetry import story
from telemetry.page import page as page_module
-from telemetry.page import page_set as page_set_module
+from telemetry.page import shared_page_state
class SkiaBuildbotDesktopPage(page_module.Page):
@@ -14,8 +15,8 @@ class SkiaBuildbotDesktopPage(page_module.Page):
super(SkiaBuildbotDesktopPage, self).__init__(
url=url,
page_set=page_set,
- credentials_path='data/credentials.json')
- self.user_agent_type = 'desktop'
+ credentials_path='data/credentials.json',
+ shared_page_state_class=shared_page_state.SharedDesktopPageState)
self.archive_data_file = 'data/skia_googlehome_desktop.json'
def RunNavigateSteps(self, action_runner):
@@ -23,13 +24,12 @@ class SkiaBuildbotDesktopPage(page_module.Page):
action_runner.Wait(5)
-class SkiaGooglehomeDesktopPageSet(page_set_module.PageSet):
+class SkiaGooglehomeDesktopPageSet(story.StorySet):
""" Pages designed to represent the median, not highly optimized web """
def __init__(self):
super(SkiaGooglehomeDesktopPageSet, self).__init__(
- user_agent_type='desktop',
archive_data_file='data/skia_googlehome_desktop.json')
urls_list = [
« no previous file with comments | « tools/skp/page_sets/skia_gmailthread_desktop.py ('k') | tools/skp/page_sets/skia_googlespreadsheet_desktop.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698