Telemetry: add a page filter for excluding pages.

Telemetry: add a page filter for excluding pages.

For Android, we need to run the tests selectively, excluding some pages.

R=nduca
BUG=none
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178787

[marja, 2013-01-23 14:29:00]

ptal

[nduca, 2013-01-23 18:01:05]

Seems to me we should have a page_filter object that has IsSelected(page),
@staticmethod AddOptionsToParser, and a __init__(options).

[marja, 2013-01-24 13:03:28]

Thanks for comments!

On 2013/01/23 18:01:05, nduca wrote:
> Seems to me we should have a page_filter object that has IsSelected(page),
> @staticmethod AddOptionsToParser, and a __init__(options).

Done (named it AddCommandLineOptions, for consistency).

[nduca, 2013-01-24 18:34:32]

lgtm but some tweaks please.

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/page_filter.py (right):

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page_filter.py:17: self.page_regex = None
self._page_regex?

its never meant to be public right?

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page_filter.py:21: self.page_exclude_regex =
re.compile(options.page_filter_exclude)
self._page_exclude_regex?

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page_filter.py:33: @staticmethod
this might want to go above __init__ in the file

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/record_wpr.py (right):

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/record_wpr.py:68:
page_filter.PageFilter.AddCommandLineOptions(parser)
This I think should call into page_runner.PageRunner.AddCommandLineOptions
[which you sould add] and that should call
page_runner.PageRunner.AddCommandLineOptions 

If you think about it, filtering is part of the page_runner

[marja, 2013-01-25 08:45:44]

Thanks for review!

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/page_filter.py (right):

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page_filter.py:17: self.page_regex = None
On 2013/01/24 18:34:32, nduca wrote:
> self._page_regex?
> 
> its never meant to be public right?

Done.

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page_filter.py:21: self.page_exclude_regex =
re.compile(options.page_filter_exclude)
On 2013/01/24 18:34:32, nduca wrote:
> self._page_exclude_regex?

Done.

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page_filter.py:33: @staticmethod
On 2013/01/24 18:34:32, nduca wrote:
> this might want to go above __init__ in the file

In all other files, __init__ is before the staticmethods, so left this here.

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/record_wpr.py (right):

https://codereview.chromium.org/12034007/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/record_wpr.py:68:
page_filter.PageFilter.AddCommandLineOptions(parser)
On 2013/01/24 18:34:32, nduca wrote:
> This I think should call into page_runner.PageRunner.AddCommandLineOptions
> [which you sould add] and that should call
> page_runner.PageRunner.AddCommandLineOptions 
> 
> If you think about it, filtering is part of the page_runner

Done.

[commit-bot: I haz the power, 2013-01-25 08:46:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/12034007/10001

[commit-bot: I haz the power, 2013-01-25 09:04:49]

Change committed as 178787