Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 12034003: Unbreak max scroll offset in threaded compositing mode. (Closed)

Created:
7 years, 11 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 11 months ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Unbreak max scroll offset in threaded compositing mode. This was broken by a cleanup in https://src.chromium.org/viewvc/chrome?view=rev&revision=177847. Reverting that part of the patch. TBR=enne NOTRY=true BUG=171188 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/layer_tree_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aelias_OOO_until_Jul13
Hi, I think we should revert this until the WebKit issue is fixed.
7 years, 11 months ago (2013-01-21 01:52:30 UTC) #1
enne (OOO)
What's the WebKit issue?
7 years, 11 months ago (2013-01-21 02:08:44 UTC) #2
enne (OOO)
Oh, sorry. I see the bug you filed. This lgtm.
7 years, 11 months ago (2013-01-21 02:10:10 UTC) #3
aelias_OOO_until_Jul13
root scroll layer bounds are sometimes (0,0). I assume this is because ScrollingCoordinatorChromium::frameViewLayoutUpdated is not ...
7 years, 11 months ago (2013-01-21 02:12:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12034003/1
7 years, 11 months ago (2013-01-21 02:13:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12034003/1
7 years, 11 months ago (2013-01-21 02:19:36 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-21 03:21:05 UTC) #7
Message was sent while issue was closed.
Change committed as 177886

Powered by Google App Engine
This is Rietveld 408576698