pkg/compiler/lib/src/js_backend/codegen/codegen.dart - Issue 1203353003: dart2js cps: Fix codegen for foreign statements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1203353003: dart2js cps: Fix codegen for foreign statements. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

index bd409191bf73e2e216d0ebc48de07a855e11f3b7..99091499f1b9b280049dfc0cca1f3fb7692a9d57 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

@@ -701,8 +701,8 @@ class CodeGenerator extends tree_ir.StatementVisitor

}

@override

- visitForeignStatement(tree_ir.ForeignStatement node) {

- return handleForeignCode(node);

+ void visitForeignStatement(tree_ir.ForeignStatement node) {

+ accumulator.add(handleForeignCode(node));

}

@override