Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: Source/platform/graphics/paint/DrawingDisplayItem.h

Issue 1203343002: WIP for display item list backed by ListContainer Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/paint/DisplayItems.cpp ('k') | Source/platform/graphics/paint/DrawingRecorder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/DrawingDisplayItem.h
diff --git a/Source/platform/graphics/paint/DrawingDisplayItem.h b/Source/platform/graphics/paint/DrawingDisplayItem.h
index 8b4b46674c109145df0a46bb5dafe0cb9d1e0305..6400dc2c897480637a21fdf488e758f271d0d8a1 100644
--- a/Source/platform/graphics/paint/DrawingDisplayItem.h
+++ b/Source/platform/graphics/paint/DrawingDisplayItem.h
@@ -22,37 +22,20 @@ public:
};
#endif
- static PassOwnPtr<DrawingDisplayItem> create(const DisplayItemClientWrapper& client
- , Type type
- , PassRefPtr<const SkPicture> picture
-#if ENABLE(ASSERT)
- , UnderInvalidationCheckingMode underInvalidationCheckingMode = CheckPicture
-#endif
- )
- {
- return adoptPtr(new DrawingDisplayItem(client
- , type
- , picture
-#if ENABLE(ASSERT)
- , underInvalidationCheckingMode
-#endif
- ));
- }
+ DrawingDisplayItem() : m_picture(nullptr) { }
- DrawingDisplayItem(const DisplayItemClientWrapper& client
- , Type type
- , PassRefPtr<const SkPicture> picture
+ void setNew(PassRefPtr<const SkPicture> picture
#if ENABLE(ASSERT)
- , UnderInvalidationCheckingMode underInvalidationCheckingMode
+ , UnderInvalidationCheckingMode underInvalidationCheckingMode = CheckPicture
#endif
)
- : DisplayItem(client, type)
- , m_picture(picture && picture->approximateOpCount() ? picture : nullptr)
{
+ if (picture && picture->approximateOpCount())
+ m_picture = picture;
#if ENABLE(ASSERT)
m_underInvalidationCheckingMode = underInvalidationCheckingMode;
#endif
- ASSERT(isDrawingType(type));
+ ASSERT(isDrawingType(type()));
}
virtual void replay(GraphicsContext&);
« no previous file with comments | « Source/platform/graphics/paint/DisplayItems.cpp ('k') | Source/platform/graphics/paint/DrawingRecorder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698