Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: Source/core/paint/Transform3DRecorder.cpp

Issue 1203343002: WIP for display item list backed by ListContainer Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/SubtreeRecorder.cpp ('k') | Source/core/paint/TransformRecorder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/Transform3DRecorder.cpp
diff --git a/Source/core/paint/Transform3DRecorder.cpp b/Source/core/paint/Transform3DRecorder.cpp
index b359b4c478b8a0a1f8461d61c5da7d87e3a387a7..723194cd106d9994a3df8bc391cf9a7c48ce34bb 100644
--- a/Source/core/paint/Transform3DRecorder.cpp
+++ b/Source/core/paint/Transform3DRecorder.cpp
@@ -23,15 +23,19 @@ Transform3DRecorder::Transform3DRecorder(GraphicsContext& context, const Display
if (m_skipRecordingForIdentityTransform)
return;
- if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
- ASSERT(m_context.displayItemList());
- if (m_context.displayItemList()->displayItemConstructionIsDisabled())
- return;
- m_context.displayItemList()->add(BeginTransform3DDisplayItem::create(m_client, m_type, transform));
- } else {
- BeginTransform3DDisplayItem beginTransform(m_client, m_type, transform);
- beginTransform.replay(m_context);
- }
+ ALLOW_UNUSED_LOCAL(m_context);
+ ALLOW_UNUSED_LOCAL(m_client);
+ ALLOW_UNUSED_LOCAL(m_type);
+ ALLOW_UNUSED_LOCAL(m_skipRecordingForIdentityTransform);
+ //if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
+ // ASSERT(m_context.displayItemList());
+ // if (m_context.displayItemList()->displayItemConstructionIsDisabled())
+ // return;
+ // m_context.displayItemList()->add(BeginTransform3DDisplayItem::create(m_client, m_type, transform));
+ //} else {
+ // BeginTransform3DDisplayItem beginTransform(m_client, m_type, transform);
+ // beginTransform.replay(m_context);
+ //}
}
Transform3DRecorder::~Transform3DRecorder()
@@ -39,19 +43,19 @@ Transform3DRecorder::~Transform3DRecorder()
if (m_skipRecordingForIdentityTransform)
return;
- DisplayItem::Type endType = DisplayItem::transform3DTypeToEndTransform3DType(m_type);
- if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
- ASSERT(m_context.displayItemList());
- if (!m_context.displayItemList()->displayItemConstructionIsDisabled()) {
- if (m_context.displayItemList()->lastDisplayItemIsNoopBegin())
- m_context.displayItemList()->removeLastDisplayItem();
- else
- m_context.displayItemList()->add(EndTransform3DDisplayItem::create(m_client, endType));
- }
- } else {
- EndTransform3DDisplayItem endTransform(m_client, endType);
- endTransform.replay(m_context);
- }
+ //DisplayItem::Type endType = DisplayItem::transform3DTypeToEndTransform3DType(m_type);
+ //if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
+ // ASSERT(m_context.displayItemList());
+ // if (!m_context.displayItemList()->displayItemConstructionIsDisabled()) {
+ // if (m_context.displayItemList()->lastDisplayItemIsNoopBegin())
+ // m_context.displayItemList()->removeLastDisplayItem();
+ // else
+ // m_context.displayItemList()->add(EndTransform3DDisplayItem::create(m_client, endType));
+ // }
+ //} else {
+ // EndTransform3DDisplayItem endTransform(m_client, endType);
+ // endTransform.replay(m_context);
+ //}
}
} // namespace blink
« no previous file with comments | « Source/core/paint/SubtreeRecorder.cpp ('k') | Source/core/paint/TransformRecorder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698