Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: Source/core/paint/ScrollRecorder.cpp

Issue 1203343002: WIP for display item list backed by ListContainer Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/SVGMaskPainter.cpp ('k') | Source/core/paint/SubtreeRecorder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/ScrollRecorder.cpp
diff --git a/Source/core/paint/ScrollRecorder.cpp b/Source/core/paint/ScrollRecorder.cpp
index cdcf9d7f2f17153d57375149e180c5ecf4554191..a2b18ae1a7d13e6679d5c8456138ca7be87d935f 100644
--- a/Source/core/paint/ScrollRecorder.cpp
+++ b/Source/core/paint/ScrollRecorder.cpp
@@ -17,32 +17,35 @@ ScrollRecorder::ScrollRecorder(GraphicsContext& context, const DisplayItemClient
, m_beginItemType(DisplayItem::paintPhaseToScrollType(phase))
, m_context(context)
{
- if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
- ASSERT(m_context.displayItemList());
- if (m_context.displayItemList()->displayItemConstructionIsDisabled())
- return;
- m_context.displayItemList()->add(BeginScrollDisplayItem::create(m_client, m_beginItemType, currentOffset));
- } else {
- BeginScrollDisplayItem scrollDisplayItem(m_client, m_beginItemType, currentOffset);
- scrollDisplayItem.replay(m_context);
- }
+ ALLOW_UNUSED_LOCAL(m_client);
+ ALLOW_UNUSED_LOCAL(m_beginItemType);
+ ALLOW_UNUSED_LOCAL(m_context);
+ //if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
+ // ASSERT(m_context.displayItemList());
+ // if (m_context.displayItemList()->displayItemConstructionIsDisabled())
+ // return;
+ // m_context.displayItemList()->add(BeginScrollDisplayItem::create(m_client, m_beginItemType, currentOffset));
+ //} else {
+ // BeginScrollDisplayItem scrollDisplayItem(m_client, m_beginItemType, currentOffset);
+ // scrollDisplayItem.replay(m_context);
+ //}
}
ScrollRecorder::~ScrollRecorder()
{
- DisplayItem::Type endItemType = DisplayItem::scrollTypeToEndScrollType(m_beginItemType);
- if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
- ASSERT(m_context.displayItemList());
- if (!m_context.displayItemList()->displayItemConstructionIsDisabled()) {
- if (m_context.displayItemList()->lastDisplayItemIsNoopBegin())
- m_context.displayItemList()->removeLastDisplayItem();
- else
- m_context.displayItemList()->add(EndScrollDisplayItem::create(m_client, endItemType));
- }
- } else {
- EndScrollDisplayItem endScrollDisplayItem(m_client, endItemType);
- endScrollDisplayItem.replay(m_context);
- }
+ //DisplayItem::Type endItemType = DisplayItem::scrollTypeToEndScrollType(m_beginItemType);
+ //if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
+ // ASSERT(m_context.displayItemList());
+ // if (!m_context.displayItemList()->displayItemConstructionIsDisabled()) {
+ // if (m_context.displayItemList()->lastDisplayItemIsNoopBegin())
+ // m_context.displayItemList()->removeLastDisplayItem();
+ // else
+ // m_context.displayItemList()->add(EndScrollDisplayItem::create(m_client, endItemType));
+ // }
+ //} else {
+ // EndScrollDisplayItem endScrollDisplayItem(m_client, endItemType);
+ // endScrollDisplayItem.replay(m_context);
+ //}
}
} // namespace blink
« no previous file with comments | « Source/core/paint/SVGMaskPainter.cpp ('k') | Source/core/paint/SubtreeRecorder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698