sync: Implementation of Priority Preferences.

chrome/browser/sync/sync_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sync_prefs.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/public/pref_member.h"
@@ skipping 326 matching lines @@
     case syncer::SYNCED_NOTIFICATIONS:
       return prefs::kSyncSyncedNotifications;
     case syncer::DICTIONARY:
       return prefs::kSyncDictionary;
     case syncer::FAVICON_IMAGES:
       return prefs::kSyncFaviconImages;
     case syncer::FAVICON_TRACKING:
       return prefs::kSyncFaviconTracking;
     case syncer::PROXY_TABS:
       return prefs::kSyncTabs;
+    case syncer::PRIORITY_PREFERENCES:
+      return prefs::kSyncPriorityPreferences;

[Mattias Nissler (ping if slow), 2013/03/21 06:50:15]

Is there any migration needed here? I.e. for existing Chrome Profiles that have
Pref sync enabled but nothing else, what should happen if priority prefs become
supported after an update?

[albertb, 2013/03/21 17:10:33]

I'm not sure about this. Nicolas/Tim: what do you think?

[tim (not reviewing), 2013/03/21 18:10:55]

We're not adding a checkbox in the UI for this, right?  So they should just get
enabled as part of prefs (I haven't checked the whole review too closely, but I
assume this is what you / Nicolas did?)

[albertb, 2013/03/21 18:46:29]

Yes, priority preferences are automatically enabled if (normal) preferences are.

     default:
       break;
   }
   NOTREACHED();
   return NULL;
 }
 
 #if defined(OS_CHROMEOS)
 std::string SyncPrefs::GetSpareBootstrapToken() const {
   DCHECK(CalledOnValidThread());
@@ skipping 45 matching lines @@
 
 void SyncPrefs::RegisterPrefGroups() {
   pref_groups_[syncer::APPS].Put(syncer::APP_NOTIFICATIONS);
   pref_groups_[syncer::APPS].Put(syncer::APP_SETTINGS);
 
   pref_groups_[syncer::AUTOFILL].Put(syncer::AUTOFILL_PROFILE);
 
   pref_groups_[syncer::EXTENSIONS].Put(syncer::EXTENSION_SETTINGS);
 
   pref_groups_[syncer::PREFERENCES].Put(syncer::DICTIONARY);
+  pref_groups_[syncer::PREFERENCES].Put(syncer::PRIORITY_PREFERENCES);
   pref_groups_[syncer::PREFERENCES].Put(syncer::SEARCH_ENGINES);
 
   pref_groups_[syncer::TYPED_URLS].Put(syncer::HISTORY_DELETE_DIRECTIVES);
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kHistoryEnableFullHistorySync)) {
     pref_groups_[syncer::TYPED_URLS].Put(syncer::SESSIONS);
     pref_groups_[syncer::TYPED_URLS].Put(syncer::FAVICON_IMAGES);
     pref_groups_[syncer::TYPED_URLS].Put(syncer::FAVICON_TRACKING);
   }
 
@@ skipping 59 matching lines @@
   for (PrefGroupsMap::const_iterator i = pref_groups_.begin();
       i != pref_groups_.end(); ++i) {
     if (types.Has(i->first))
       types_with_groups.PutAll(i->second);
   }
   types_with_groups.RetainAll(registered_types);
   return types_with_groups;
 }
 
 }  // namespace browser_sync